diff options
author | Rémi Verschelde <rverschelde@gmail.com> | 2023-02-01 10:54:22 +0100 |
---|---|---|
committer | Rémi Verschelde <rverschelde@gmail.com> | 2023-02-01 10:54:22 +0100 |
commit | afe3b94ab28a28d562fd96f3daf41a22cb26757a (patch) | |
tree | 1b2e0cfc8e529ae652f79c286495527883581fa6 /modules/gdscript/gdscript_warning.h | |
parent | f7397a5ac6bffc0df24cae61b8aabfa4a3b65347 (diff) |
Revert "GDScript: Add warnings that are set to error by default"
This reverts commit a166833bfa23a21a7bff196a85a20b014e7c1396.
This caused multiple regressions.
Needs to be redone with more testing before merge.
Fixes #72501.
Diffstat (limited to 'modules/gdscript/gdscript_warning.h')
-rw-r--r-- | modules/gdscript/gdscript_warning.h | 49 |
1 files changed, 0 insertions, 49 deletions
diff --git a/modules/gdscript/gdscript_warning.h b/modules/gdscript/gdscript_warning.h index f0123c518c..fa2907cdae 100644 --- a/modules/gdscript/gdscript_warning.h +++ b/modules/gdscript/gdscript_warning.h @@ -82,58 +82,9 @@ public: STATIC_CALLED_ON_INSTANCE, // A static method was called on an instance of a class instead of on the class itself. CONFUSABLE_IDENTIFIER, // The identifier contains misleading characters that can be confused. E.g. "usеr" (has Cyrillic "е" instead of Latin "e"). RENAMED_IN_GD4_HINT, // A variable or function that could not be found has been renamed in Godot 4 - INFERENCE_ON_VARIANT, // The declaration uses type inference but the value is typed as Variant. - NATIVE_METHOD_OVERRIDE, // The script method overrides a native one, this may not work as intended. - GET_NODE_DEFAULT_WITHOUT_ONREADY, // A class variable uses `get_node()` (or the `$` notation) as its default value, but does not use the @onready annotation. - ONREADY_WITH_EXPORT, // The `@onready` annotation will set the value after `@export` which is likely not intended. WARNING_MAX, }; - constexpr static WarnLevel default_warning_levels[] = { - WARN, // UNASSIGNED_VARIABLE - WARN, // UNASSIGNED_VARIABLE_OP_ASSIGN - WARN, // UNUSED_VARIABLE - WARN, // UNUSED_LOCAL_CONSTANT - WARN, // SHADOWED_VARIABLE - WARN, // SHADOWED_VARIABLE_BASE_CLASS - WARN, // UNUSED_PRIVATE_CLASS_VARIABLE - WARN, // UNUSED_PARAMETER - WARN, // UNREACHABLE_CODE - WARN, // UNREACHABLE_PATTERN - WARN, // STANDALONE_EXPRESSION - WARN, // NARROWING_CONVERSION - WARN, // INCOMPATIBLE_TERNARY - WARN, // UNUSED_SIGNAL - IGNORE, // RETURN_VALUE_DISCARDED // Too spammy by default on common cases (connect, Tween, etc.). - WARN, // PROPERTY_USED_AS_FUNCTION - WARN, // CONSTANT_USED_AS_FUNCTION - WARN, // FUNCTION_USED_AS_PROPERTY - WARN, // INTEGER_DIVISION - IGNORE, // UNSAFE_PROPERTY_ACCESS // Too common in untyped scenarios. - IGNORE, // UNSAFE_METHOD_ACCESS // Too common in untyped scenarios. - IGNORE, // UNSAFE_CAST // Too common in untyped scenarios. - IGNORE, // UNSAFE_CALL_ARGUMENT // Too common in untyped scenarios. - WARN, // UNSAFE_VOID_RETURN - WARN, // DEPRECATED_KEYWORD - WARN, // STANDALONE_TERNARY - WARN, // ASSERT_ALWAYS_TRUE - WARN, // ASSERT_ALWAYS_FALSE - WARN, // REDUNDANT_AWAIT - WARN, // EMPTY_FILE - WARN, // SHADOWED_GLOBAL_IDENTIFIER - WARN, // INT_AS_ENUM_WITHOUT_CAST - WARN, // INT_AS_ENUM_WITHOUT_MATCH - WARN, // STATIC_CALLED_ON_INSTANCE - WARN, // CONFUSABLE_IDENTIFIER - WARN, // RENAMED_IN_GD4_HINT - ERROR, // INFERENCE_ON_VARIANT // Most likely done by accident, usually inference is trying for a particular type. - ERROR, // NATIVE_METHOD_OVERRIDE // May not work as expected. - ERROR, // GET_NODE_DEFAULT_WITHOUT_ONREADY // May not work as expected. - ERROR, // ONREADY_WITH_EXPORT // May not work as expected. - }; - - static_assert((sizeof(default_warning_levels) / sizeof(default_warning_levels[0])) == WARNING_MAX, "Amount of default levels does not match the amount of warnings."); - Code code = WARNING_MAX; int start_line = -1, end_line = -1; int leftmost_column = -1, rightmost_column = -1; |