summaryrefslogtreecommitdiff
path: root/editor
diff options
context:
space:
mode:
authoralex-pahdo <109116583+alex-pahdo@users.noreply.github.com>2022-10-24 13:30:37 -0700
committerRĂ©mi Verschelde <rverschelde@gmail.com>2022-11-14 15:09:48 +0100
commitf5d256b118914817e2c7ac5c35421e2767fc1e79 (patch)
tree3fc6abaff3a46f21b81320f5433e9a9308c2a13d /editor
parent471c42ee1fe2c84b4f248e7194a2b10b562ff508 (diff)
Add more info to WAV import errors
Print mismatched header contents and file size, which can provide more clues to users when debugging.
Diffstat (limited to 'editor')
-rw-r--r--editor/import/resource_importer_wav.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/editor/import/resource_importer_wav.cpp b/editor/import/resource_importer_wav.cpp
index 1dcae2841b..f5a0f0abcf 100644
--- a/editor/import/resource_importer_wav.cpp
+++ b/editor/import/resource_importer_wav.cpp
@@ -107,7 +107,7 @@ Error ResourceImporterWAV::import(const String &p_source_file, const String &p_s
file->get_buffer((uint8_t *)&riff, 4); //RIFF
if (riff[0] != 'R' || riff[1] != 'I' || riff[2] != 'F' || riff[3] != 'F') {
- ERR_FAIL_V(ERR_FILE_UNRECOGNIZED);
+ ERR_FAIL_V_MSG(ERR_FILE_UNRECOGNIZED, vformat("Not a WAV file. File should start with 'RIFF', but found '%s', in file of size %d bytes", riff, file->get_length()));
}
/* GET FILESIZE */
@@ -115,12 +115,12 @@ Error ResourceImporterWAV::import(const String &p_source_file, const String &p_s
/* CHECK WAVE */
- char wave[4];
-
- file->get_buffer((uint8_t *)&wave, 4); //RIFF
+ char wave[5];
+ wave[4] = 0;
+ file->get_buffer((uint8_t *)&wave, 4); //WAVE
if (wave[0] != 'W' || wave[1] != 'A' || wave[2] != 'V' || wave[3] != 'E') {
- ERR_FAIL_V_MSG(ERR_FILE_UNRECOGNIZED, "Not a WAV file (no WAVE RIFF header).");
+ ERR_FAIL_V_MSG(ERR_FILE_UNRECOGNIZED, vformat("Not a WAV file. Header should contain 'WAVE', but found '%s', in file of size %d bytes", wave, file->get_length()));
}
// Let users override potential loop points from the WAV.