diff options
| author | Hein-Pieter van Braam <hp@tmm.cx> | 2017-08-24 22:58:51 +0200 |
|---|---|---|
| committer | Hein-Pieter van Braam <hp@tmm.cx> | 2017-08-24 23:08:24 +0200 |
| commit | cacced7e507f7603bacc03ae2616e58f0ede122a (patch) | |
| tree | 7af89373e86cd1a7af6ea04e10280084cabb7144 /editor/resources_dock.cpp | |
| parent | 4aa2c18cb428ffde05c67987926736a9ca62703b (diff) | |
Convert Object::cast_to() to the static version
Currently we rely on some undefined behavior when Object->cast_to() gets
called with a Null pointer. This used to work fine with GCC < 6 but
newer versions of GCC remove all codepaths in which the this pointer is
Null. However, the non-static cast_to() was supposed to be null safe.
This patch makes cast_to() Null safe and removes the now redundant Null
checks where they existed.
It is explained in this article: https://www.viva64.com/en/b/0226/
Diffstat (limited to 'editor/resources_dock.cpp')
| -rw-r--r-- | editor/resources_dock.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/editor/resources_dock.cpp b/editor/resources_dock.cpp index db3bf6a352..dcff3bcd73 100644 --- a/editor/resources_dock.cpp +++ b/editor/resources_dock.cpp @@ -279,7 +279,7 @@ void ResourcesDock::_resource_selected() { void ResourcesDock::_delete(Object *p_item, int p_column, int p_id) { - TreeItem *ti = p_item->cast_to<TreeItem>(); + TreeItem *ti = Object::cast_to<TreeItem>(p_item); ERR_FAIL_COND(!ti); call_deferred("remove_resource", ti->get_metadata(0)); @@ -290,7 +290,7 @@ void ResourcesDock::_create() { Object *c = create_dialog->instance_selected(); ERR_FAIL_COND(!c); - Resource *r = c->cast_to<Resource>(); + Resource *r = Object::cast_to<Resource>(c); ERR_FAIL_COND(!r); REF res(r); |