diff options
| author | Rémi Verschelde <rverschelde@gmail.com> | 2023-01-17 17:30:58 +0100 |
|---|---|---|
| committer | Rémi Verschelde <rverschelde@gmail.com> | 2023-01-17 17:30:58 +0100 |
| commit | ae766558f0b3f4f9f794bcb80de945eeea2e3209 (patch) | |
| tree | 93980ae55365758d185fda48c7eefa841fb73b3a /editor/plugins | |
| parent | 3a53990e9c028412c00cba9357adeb8d0491e759 (diff) | |
| parent | 85aa03baaf179707fabbb3e7fa07a989f5535c23 (diff) | |
Merge pull request #71528 from snakept/missing-path-external-editor-error
Checking path variable if empty before opening external editor to fix…
Diffstat (limited to 'editor/plugins')
| -rw-r--r-- | editor/plugins/script_editor_plugin.cpp | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/editor/plugins/script_editor_plugin.cpp b/editor/plugins/script_editor_plugin.cpp index 4268abe4a2..8777b73540 100644 --- a/editor/plugins/script_editor_plugin.cpp +++ b/editor/plugins/script_editor_plugin.cpp @@ -2256,11 +2256,14 @@ bool ScriptEditor::edit(const Ref<Resource> &p_resource, int p_line, int p_col, args.push_back(script_path); } - Error err = OS::get_singleton()->create_process(path, args); - if (err == OK) { - return false; + if (!path.is_empty()) { + Error err = OS::get_singleton()->create_process(path, args); + if (err == OK) { + return false; + } } - WARN_PRINT("Couldn't open external text editor, using internal"); + + ERR_PRINT("Couldn't open external text editor, falling back to the internal editor. Review your `text_editor/external/` editor settings."); } for (int i = 0; i < tab_container->get_tab_count(); i++) { |