diff options
| author | Haoyu Qiu <timothyqiu32@gmail.com> | 2022-12-30 14:15:30 +0800 |
|---|---|---|
| committer | Haoyu Qiu <timothyqiu32@gmail.com> | 2022-12-30 14:16:54 +0800 |
| commit | 1ac35c38be336207ac7a8df7a769efe6e0a09ba4 (patch) | |
| tree | f346f1b78181d7e4bf6f2f0aa46d4029d25fed21 /editor/plugins | |
| parent | 0daa86d70e7338506c37bee6b6e0c4aba7255d68 (diff) | |
Fix heap-use-after-free when using TileMap editor
Diffstat (limited to 'editor/plugins')
| -rw-r--r-- | editor/plugins/tiles/tile_map_editor.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/editor/plugins/tiles/tile_map_editor.cpp b/editor/plugins/tiles/tile_map_editor.cpp index 5a1f214933..414c3a2759 100644 --- a/editor/plugins/tiles/tile_map_editor.cpp +++ b/editor/plugins/tiles/tile_map_editor.cpp @@ -1488,13 +1488,15 @@ void TileMapEditorTilesPlugin::_update_fix_selected_and_hovered() { } // Selection if needed. - for (RBSet<TileMapCell>::Element *E = tile_set_selection.front(); E; E = E->next()) { + for (RBSet<TileMapCell>::Element *E = tile_set_selection.front(); E;) { + RBSet<TileMapCell>::Element *N = E->next(); const TileMapCell *selected = &(E->get()); if (!tile_set->has_source(selected->source_id) || !tile_set->get_source(selected->source_id)->has_tile(selected->get_atlas_coords()) || !tile_set->get_source(selected->source_id)->has_alternative_tile(selected->get_atlas_coords(), selected->alternative_tile)) { tile_set_selection.erase(E); } + E = N; } if (!tile_map_selection.is_empty()) { |