diff options
author | RĂ©mi Verschelde <rverschelde@gmail.com> | 2020-05-14 23:09:03 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-05-14 23:09:03 +0200 |
commit | 00949f0c5fcc6a4f8382a4a97d5591fd9ec380f8 (patch) | |
tree | 2b1c31f45add24085b64425ce440f577424c16a1 /editor/editor_data.cpp | |
parent | 5046f666a1181675b39f156c38346525dc1c444e (diff) | |
parent | 0ee0fa42e6639b6fa474b7cf6afc6b1a78142185 (diff) |
Merge pull request #38738 from akien-mga/cause-we-never-go-out-of-style
Style: Remove new line at block start, enforce line between functions, enforce braces in if and loop blocks
Diffstat (limited to 'editor/editor_data.cpp')
-rw-r--r-- | editor/editor_data.cpp | 281 |
1 files changed, 120 insertions, 161 deletions
diff --git a/editor/editor_data.cpp b/editor/editor_data.cpp index 9c739474d1..130c330f5a 100644 --- a/editor/editor_data.cpp +++ b/editor/editor_data.cpp @@ -39,22 +39,23 @@ #include "scene/resources/packed_scene.h" void EditorHistory::cleanup_history() { - for (int i = 0; i < history.size(); i++) { - bool fail = false; for (int j = 0; j < history[i].path.size(); j++) { - if (!history[i].path[j].ref.is_null()) + if (!history[i].path[j].ref.is_null()) { continue; + } Object *obj = ObjectDB::get_instance(history[i].path[j].object); if (obj) { Node *n = Object::cast_to<Node>(obj); - if (n && n->is_inside_tree()) + if (n && n->is_inside_tree()) { continue; - if (!n) // Possibly still alive + } + if (!n) { // Possibly still alive continue; + } } if (j <= history[i].level) { @@ -74,18 +75,19 @@ void EditorHistory::cleanup_history() { } } - if (current >= history.size()) + if (current >= history.size()) { current = history.size() - 1; + } } void EditorHistory::_add_object(ObjectID p_object, const String &p_property, int p_level_change, bool p_inspector_only) { - Object *obj = ObjectDB::get_instance(p_object); ERR_FAIL_COND(!obj); Reference *r = Object::cast_to<Reference>(obj); Obj o; - if (r) + if (r) { o.ref = REF(r); + } o.object = p_object; o.property = p_property; o.inspector_only = p_inspector_only; @@ -122,34 +124,30 @@ void EditorHistory::_add_object(ObjectID p_object, const String &p_property, int } void EditorHistory::add_object_inspector_only(ObjectID p_object) { - _add_object(p_object, "", -1, true); } void EditorHistory::add_object(ObjectID p_object) { - _add_object(p_object, "", -1); } void EditorHistory::add_object(ObjectID p_object, const String &p_subprop) { - _add_object(p_object, p_subprop, -1); } void EditorHistory::add_object(ObjectID p_object, int p_relevel) { - _add_object(p_object, "", p_relevel); } int EditorHistory::get_history_len() { return history.size(); } + int EditorHistory::get_history_pos() { return current; } bool EditorHistory::is_history_obj_inspector_only(int p_obj) const { - ERR_FAIL_INDEX_V(p_obj, history.size(), false); ERR_FAIL_INDEX_V(history[p_obj].level, history[p_obj].path.size(), false); return history[p_obj].path[history[p_obj].level].inspector_only; @@ -164,85 +162,88 @@ ObjectID EditorHistory::get_history_obj(int p_obj) const { bool EditorHistory::is_at_beginning() const { return current <= 0; } -bool EditorHistory::is_at_end() const { +bool EditorHistory::is_at_end() const { return ((current + 1) >= history.size()); } bool EditorHistory::next() { - cleanup_history(); - if ((current + 1) < history.size()) + if ((current + 1) < history.size()) { current++; - else + } else { return false; + } return true; } bool EditorHistory::previous() { - cleanup_history(); - if (current > 0) + if (current > 0) { current--; - else + } else { return false; + } return true; } bool EditorHistory::is_current_inspector_only() const { - - if (current < 0 || current >= history.size()) + if (current < 0 || current >= history.size()) { return false; + } const History &h = history[current]; return h.path[h.level].inspector_only; } -ObjectID EditorHistory::get_current() { - if (current < 0 || current >= history.size()) +ObjectID EditorHistory::get_current() { + if (current < 0 || current >= history.size()) { return ObjectID(); + } History &h = history.write[current]; Object *obj = ObjectDB::get_instance(h.path[h.level].object); - if (!obj) + if (!obj) { return ObjectID(); + } return obj->get_instance_id(); } int EditorHistory::get_path_size() const { - - if (current < 0 || current >= history.size()) + if (current < 0 || current >= history.size()) { return 0; + } const History &h = history[current]; return h.path.size(); } ObjectID EditorHistory::get_path_object(int p_index) const { - - if (current < 0 || current >= history.size()) + if (current < 0 || current >= history.size()) { return ObjectID(); + } const History &h = history[current]; ERR_FAIL_INDEX_V(p_index, h.path.size(), ObjectID()); Object *obj = ObjectDB::get_instance(h.path[p_index].object); - if (!obj) + if (!obj) { return ObjectID(); + } return obj->get_instance_id(); } String EditorHistory::get_path_property(int p_index) const { - - if (current < 0 || current >= history.size()) + if (current < 0 || current >= history.size()) { return ""; + } const History &h = history[current]; @@ -252,33 +253,29 @@ String EditorHistory::get_path_property(int p_index) const { } void EditorHistory::clear() { - history.clear(); current = -1; } EditorHistory::EditorHistory() { - current = -1; } EditorPlugin *EditorData::get_editor(Object *p_object) { - for (int i = 0; i < editor_plugins.size(); i++) { - - if (editor_plugins[i]->has_main_screen() && editor_plugins[i]->handles(p_object)) + if (editor_plugins[i]->has_main_screen() && editor_plugins[i]->handles(p_object)) { return editor_plugins[i]; + } } return nullptr; } EditorPlugin *EditorData::get_subeditor(Object *p_object) { - for (int i = 0; i < editor_plugins.size(); i++) { - - if (!editor_plugins[i]->has_main_screen() && editor_plugins[i]->handles(p_object)) + if (!editor_plugins[i]->has_main_screen() && editor_plugins[i]->handles(p_object)) { return editor_plugins[i]; + } } return nullptr; @@ -295,27 +292,25 @@ Vector<EditorPlugin *> EditorData::get_subeditors(Object *p_object) { } EditorPlugin *EditorData::get_editor(String p_name) { - for (int i = 0; i < editor_plugins.size(); i++) { - - if (editor_plugins[i]->get_name() == p_name) + if (editor_plugins[i]->get_name() == p_name) { return editor_plugins[i]; + } } return nullptr; } void EditorData::copy_object_params(Object *p_object) { - clipboard.clear(); List<PropertyInfo> pinfo; p_object->get_property_list(&pinfo); for (List<PropertyInfo>::Element *E = pinfo.front(); E; E = E->next()) { - - if (!(E->get().usage & PROPERTY_USAGE_EDITOR) || E->get().name == "script" || E->get().name == "scripts") + if (!(E->get().usage & PROPERTY_USAGE_EDITOR) || E->get().name == "script" || E->get().name == "scripts") { continue; + } PropertyData pd; pd.name = E->get().name; @@ -325,21 +320,18 @@ void EditorData::copy_object_params(Object *p_object) { } void EditorData::get_editor_breakpoints(List<String> *p_breakpoints) { - for (int i = 0; i < editor_plugins.size(); i++) { - editor_plugins[i]->get_breakpoints(p_breakpoints); } } Dictionary EditorData::get_editor_states() const { - Dictionary metadata; for (int i = 0; i < editor_plugins.size(); i++) { - Dictionary state = editor_plugins[i]->get_state(); - if (state.empty()) + if (state.empty()) { continue; + } metadata[editor_plugins[i]->get_name()] = state; } @@ -353,88 +345,71 @@ Dictionary EditorData::get_scene_editor_states(int p_idx) const { } void EditorData::set_editor_states(const Dictionary &p_states) { - List<Variant> keys; p_states.get_key_list(&keys); List<Variant>::Element *E = keys.front(); for (; E; E = E->next()) { - String name = E->get(); int idx = -1; for (int i = 0; i < editor_plugins.size(); i++) { - if (editor_plugins[i]->get_name() == name) { idx = i; break; } } - if (idx == -1) + if (idx == -1) { continue; + } editor_plugins[idx]->set_state(p_states[name]); } } void EditorData::notify_edited_scene_changed() { - for (int i = 0; i < editor_plugins.size(); i++) { - editor_plugins[i]->edited_scene_changed(); editor_plugins[i]->notify_scene_changed(get_edited_scene_root()); } } void EditorData::notify_resource_saved(const Ref<Resource> &p_resource) { - for (int i = 0; i < editor_plugins.size(); i++) { - editor_plugins[i]->notify_resource_saved(p_resource); } } void EditorData::clear_editor_states() { - for (int i = 0; i < editor_plugins.size(); i++) { - editor_plugins[i]->clear(); } } void EditorData::save_editor_external_data() { - for (int i = 0; i < editor_plugins.size(); i++) { - editor_plugins[i]->save_external_data(); } } void EditorData::apply_changes_in_editors() { - for (int i = 0; i < editor_plugins.size(); i++) { - editor_plugins[i]->apply_changes(); } } void EditorData::save_editor_global_states() { - for (int i = 0; i < editor_plugins.size(); i++) { - editor_plugins[i]->save_global_state(); } } void EditorData::restore_editor_global_states() { - for (int i = 0; i < editor_plugins.size(); i++) { - editor_plugins[i]->restore_global_state(); } } void EditorData::paste_object_params(Object *p_object) { - ERR_FAIL_NULL(p_object); undo_redo.create_action(TTR("Paste Params")); for (List<PropertyData>::Element *E = clipboard.front(); E; E = E->next()) { @@ -446,11 +421,9 @@ void EditorData::paste_object_params(Object *p_object) { } bool EditorData::call_build() { - bool result = true; for (int i = 0; i < editor_plugins.size() && result; i++) { - result &= editor_plugins[i]->build(); } @@ -458,18 +431,15 @@ bool EditorData::call_build() { } UndoRedo &EditorData::get_undo_redo() { - return undo_redo; } void EditorData::remove_editor_plugin(EditorPlugin *p_plugin) { - p_plugin->undo_redo = nullptr; editor_plugins.erase(p_plugin); } void EditorData::add_editor_plugin(EditorPlugin *p_plugin) { - p_plugin->undo_redo = &undo_redo; editor_plugins.push_back(p_plugin); } @@ -477,14 +447,13 @@ void EditorData::add_editor_plugin(EditorPlugin *p_plugin) { int EditorData::get_editor_plugin_count() const { return editor_plugins.size(); } -EditorPlugin *EditorData::get_editor_plugin(int p_idx) { +EditorPlugin *EditorData::get_editor_plugin(int p_idx) { ERR_FAIL_INDEX_V(p_idx, editor_plugins.size(), nullptr); return editor_plugins[p_idx]; } void EditorData::add_custom_type(const String &p_type, const String &p_inherits, const Ref<Script> &p_script, const Ref<Texture2D> &p_icon) { - ERR_FAIL_COND_MSG(p_script.is_null(), "It's not a reference to a valid Script object."); CustomType ct; ct.name = p_type; @@ -498,9 +467,7 @@ void EditorData::add_custom_type(const String &p_type, const String &p_inherits, } Object *EditorData::instance_custom_type(const String &p_type, const String &p_inherits) { - if (get_custom_types().has(p_inherits)) { - for (int i = 0; i < get_custom_types()[p_inherits].size(); i++) { if (get_custom_types()[p_inherits][i].name == p_type) { Ref<Script> script = get_custom_types()[p_inherits][i].script; @@ -520,9 +487,7 @@ Object *EditorData::instance_custom_type(const String &p_type, const String &p_i } void EditorData::remove_custom_type(const String &p_type) { - for (Map<String, Vector<CustomType>>::Element *E = custom_types.front(); E; E = E->next()) { - for (int i = 0; i < E->get().size(); i++) { if (E->get()[i].name == p_type) { E->get().remove(i); @@ -536,9 +501,9 @@ void EditorData::remove_custom_type(const String &p_type) { } int EditorData::add_edited_scene(int p_at_pos) { - - if (p_at_pos < 0) + if (p_at_pos < 0) { p_at_pos = edited_scene.size(); + } EditedScene es; es.root = nullptr; es.path = String(); @@ -546,18 +511,19 @@ int EditorData::add_edited_scene(int p_at_pos) { es.version = 0; es.live_edit_root = NodePath(String("/root")); - if (p_at_pos == edited_scene.size()) + if (p_at_pos == edited_scene.size()) { edited_scene.push_back(es); - else + } else { edited_scene.insert(p_at_pos, es); + } - if (current_edited_scene < 0) + if (current_edited_scene < 0) { current_edited_scene = 0; + } return p_at_pos; } void EditorData::move_edited_scene_index(int p_idx, int p_to_idx) { - ERR_FAIL_INDEX(p_idx, edited_scene.size()); ERR_FAIL_INDEX(p_to_idx, edited_scene.size()); SWAP(edited_scene.write[p_idx], edited_scene.write[p_to_idx]); @@ -566,7 +532,6 @@ void EditorData::move_edited_scene_index(int p_idx, int p_to_idx) { void EditorData::remove_scene(int p_idx) { ERR_FAIL_INDEX(p_idx, edited_scene.size()); if (edited_scene[p_idx].root) { - for (int i = 0; i < editor_plugins.size(); i++) { editor_plugins[i]->notify_scene_closed(edited_scene[p_idx].root->get_filename()); } @@ -574,9 +539,9 @@ void EditorData::remove_scene(int p_idx) { memdelete(edited_scene[p_idx].root); } - if (current_edited_scene > p_idx) + if (current_edited_scene > p_idx) { current_edited_scene--; - else if (current_edited_scene == p_idx && current_edited_scene > 0) { + } else if (current_edited_scene == p_idx && current_edited_scene > 0) { current_edited_scene--; } @@ -584,7 +549,6 @@ void EditorData::remove_scene(int p_idx) { } bool EditorData::_find_updated_instances(Node *p_root, Node *p_node, Set<String> &checked_paths) { - /* if (p_root!=p_node && p_node->get_owner()!=p_root && !p_root->is_editable_instance(p_node->get_owner())) return false; @@ -602,7 +566,6 @@ bool EditorData::_find_updated_instances(Node *p_root, Node *p_node, Set<String> String path = ss->get_path(); if (!checked_paths.has(path)) { - uint64_t modified_time = FileAccess::get_modified_time(path); if (modified_time != ss->get_last_modified_time()) { return true; //external scene changed @@ -613,20 +576,20 @@ bool EditorData::_find_updated_instances(Node *p_root, Node *p_node, Set<String> } for (int i = 0; i < p_node->get_child_count(); i++) { - bool found = _find_updated_instances(p_root, p_node->get_child(i), checked_paths); - if (found) + if (found) { return true; + } } return false; } bool EditorData::check_and_update_scene(int p_idx) { - ERR_FAIL_INDEX_V(p_idx, edited_scene.size(), false); - if (!edited_scene[p_idx].root) + if (!edited_scene[p_idx].root) { return false; + } Set<String> checked_scenes; @@ -650,16 +613,18 @@ bool EditorData::check_and_update_scene(int p_idx) { for (List<Node *>::Element *E = edited_scene.write[p_idx].selection.front(); E; E = E->next()) { NodePath p = edited_scene[p_idx].root->get_path_to(E->get()); Node *new_node = new_scene->get_node(p); - if (new_node) + if (new_node) { new_selection.push_back(new_node); + } } new_scene->set_filename(edited_scene[p_idx].root->get_filename()); memdelete(edited_scene[p_idx].root); edited_scene.write[p_idx].root = new_scene; - if (new_scene->get_filename() != "") + if (new_scene->get_filename() != "") { edited_scene.write[p_idx].path = new_scene->get_filename(); + } edited_scene.write[p_idx].selection = new_selection; return true; @@ -669,15 +634,15 @@ bool EditorData::check_and_update_scene(int p_idx) { } int EditorData::get_edited_scene() const { - return current_edited_scene; } -void EditorData::set_edited_scene(int p_idx) { +void EditorData::set_edited_scene(int p_idx) { ERR_FAIL_INDEX(p_idx, edited_scene.size()); current_edited_scene = p_idx; //swap } + Node *EditorData::get_edited_scene_root(int p_idx) { if (p_idx < 0) { ERR_FAIL_INDEX_V(current_edited_scene, edited_scene.size(), nullptr); @@ -687,25 +652,24 @@ Node *EditorData::get_edited_scene_root(int p_idx) { return edited_scene[p_idx].root; } } -void EditorData::set_edited_scene_root(Node *p_root) { +void EditorData::set_edited_scene_root(Node *p_root) { ERR_FAIL_INDEX(current_edited_scene, edited_scene.size()); edited_scene.write[current_edited_scene].root = p_root; if (p_root) { - if (p_root->get_filename() != "") + if (p_root->get_filename() != "") { edited_scene.write[current_edited_scene].path = p_root->get_filename(); - else + } else { p_root->set_filename(edited_scene[current_edited_scene].path); + } } } int EditorData::get_edited_scene_count() const { - return edited_scene.size(); } Vector<EditorData::EditedScene> EditorData::get_edited_scenes() const { - Vector<EditedScene> out_edited_scenes_list = Vector<EditedScene>(); for (int i = 0; i < edited_scene.size(); i++) { @@ -726,24 +690,24 @@ void EditorData::set_edited_scene_version(uint64_t version, int p_scene_idx) { } uint64_t EditorData::get_edited_scene_version() const { - ERR_FAIL_INDEX_V(current_edited_scene, edited_scene.size(), 0); return edited_scene[current_edited_scene].version; } + uint64_t EditorData::get_scene_version(int p_idx) const { ERR_FAIL_INDEX_V(p_idx, edited_scene.size(), 0); return edited_scene[p_idx].version; } String EditorData::get_scene_type(int p_idx) const { - ERR_FAIL_INDEX_V(p_idx, edited_scene.size(), String()); - if (!edited_scene[p_idx].root) + if (!edited_scene[p_idx].root) { return ""; + } return edited_scene[p_idx].root->get_class(); } -void EditorData::move_edited_scene_to_index(int p_idx) { +void EditorData::move_edited_scene_to_index(int p_idx) { ERR_FAIL_INDEX(current_edited_scene, edited_scene.size()); ERR_FAIL_INDEX(p_idx, edited_scene.size()); @@ -754,10 +718,10 @@ void EditorData::move_edited_scene_to_index(int p_idx) { } Ref<Script> EditorData::get_scene_root_script(int p_idx) const { - ERR_FAIL_INDEX_V(p_idx, edited_scene.size(), Ref<Script>()); - if (!edited_scene[p_idx].root) + if (!edited_scene[p_idx].root) { return Ref<Script>(); + } Ref<Script> s = edited_scene[p_idx].root->get_script(); if (!s.is_valid() && edited_scene[p_idx].root->get_child_count()) { Node *n = edited_scene[p_idx].root->get_child(0); @@ -771,10 +735,12 @@ Ref<Script> EditorData::get_scene_root_script(int p_idx) const { String EditorData::get_scene_title(int p_idx) const { ERR_FAIL_INDEX_V(p_idx, edited_scene.size(), String()); - if (!edited_scene[p_idx].root) + if (!edited_scene[p_idx].root) { return TTR("[empty]"); - if (edited_scene[p_idx].root->get_filename() == "") + } + if (edited_scene[p_idx].root->get_filename() == "") { return TTR("[unsaved]"); + } bool show_ext = EDITOR_DEF("interface/scene_tabs/show_extension", false); String name = edited_scene[p_idx].root->get_filename().get_file(); if (!show_ext) { @@ -784,24 +750,24 @@ String EditorData::get_scene_title(int p_idx) const { } void EditorData::set_scene_path(int p_idx, const String &p_path) { - ERR_FAIL_INDEX(p_idx, edited_scene.size()); edited_scene.write[p_idx].path = p_path; - if (!edited_scene[p_idx].root) + if (!edited_scene[p_idx].root) { return; + } edited_scene[p_idx].root->set_filename(p_path); } String EditorData::get_scene_path(int p_idx) const { - ERR_FAIL_INDEX_V(p_idx, edited_scene.size(), String()); if (edited_scene[p_idx].root) { - if (edited_scene[p_idx].root->get_filename() == "") + if (edited_scene[p_idx].root->get_filename() == "") { edited_scene[p_idx].root->set_filename(edited_scene[p_idx].path); - else + } else { return edited_scene[p_idx].root->get_filename(); + } } return edited_scene[p_idx].path; @@ -812,15 +778,14 @@ void EditorData::set_edited_scene_live_edit_root(const NodePath &p_root) { edited_scene.write[current_edited_scene].live_edit_root = p_root; } -NodePath EditorData::get_edited_scene_live_edit_root() { +NodePath EditorData::get_edited_scene_live_edit_root() { ERR_FAIL_INDEX_V(current_edited_scene, edited_scene.size(), String()); return edited_scene[current_edited_scene].live_edit_root; } void EditorData::save_edited_scene_state(EditorSelection *p_selection, EditorHistory *p_history, const Dictionary &p_custom) { - ERR_FAIL_INDEX(current_edited_scene, edited_scene.size()); EditedScene &es = edited_scene.write[current_edited_scene]; @@ -849,7 +814,6 @@ Dictionary EditorData::restore_edited_scene_state(EditorSelection *p_selection, } void EditorData::clear_edited_scenes() { - for (int i = 0; i < edited_scene.size(); i++) { if (edited_scene[i].root) { memdelete(edited_scene[i].root); @@ -871,8 +835,9 @@ void EditorData::get_plugin_window_layout(Ref<ConfigFile> p_layout) { } bool EditorData::script_class_is_parent(const String &p_class, const String &p_inherits) { - if (!ScriptServer::is_global_class(p_class)) + if (!ScriptServer::is_global_class(p_class)) { return false; + } String base = script_class_get_base(p_class); Ref<Script> script = script_class_load_script(p_class); Ref<Script> base_script = script->get_base_script(); @@ -892,10 +857,10 @@ bool EditorData::script_class_is_parent(const String &p_class, const String &p_i } StringName EditorData::script_class_get_base(const String &p_class) const { - Ref<Script> script = script_class_load_script(p_class); - if (script.is_null()) + if (script.is_null()) { return StringName(); + } Ref<Script> base_script = script->get_base_script(); if (base_script.is_null()) { @@ -910,8 +875,9 @@ Object *EditorData::script_class_instance(const String &p_class) { Object *obj = ClassDB::instance(ScriptServer::get_global_class_native_base(p_class)); if (obj) { Ref<Script> script = script_class_load_script(p_class); - if (script.is_valid()) + if (script.is_valid()) { obj->set_script(script); + } return obj; } } @@ -919,9 +885,9 @@ Object *EditorData::script_class_instance(const String &p_class) { } Ref<Script> EditorData::script_class_load_script(const String &p_class) const { - - if (!ScriptServer::is_global_class(p_class)) + if (!ScriptServer::is_global_class(p_class)) { return Ref<Script>(); + } String path = ScriptServer::get_global_class_path(p_class); return ResourceLoader::load(path, "Script"); @@ -932,15 +898,17 @@ void EditorData::script_class_set_icon_path(const String &p_class, const String } String EditorData::script_class_get_icon_path(const String &p_class) const { - if (!ScriptServer::is_global_class(p_class)) + if (!ScriptServer::is_global_class(p_class)) { return String(); + } String current = p_class; String ret = _script_class_icon_paths[current]; while (ret.empty()) { current = script_class_get_base(current); - if (!ScriptServer::is_global_class(current)) + if (!ScriptServer::is_global_class(current)) { return String(); + } ret = _script_class_icon_paths.has(current) ? _script_class_icon_paths[current] : String(); } @@ -961,8 +929,9 @@ void EditorData::script_class_save_icon_paths() { Dictionary d; for (List<StringName>::Element *E = keys.front(); E; E = E->next()) { - if (ScriptServer::is_global_class(E->get())) + if (ScriptServer::is_global_class(E->get())) { d[E->get()] = _script_class_icon_paths[E->get()]; + } } ProjectSettings::get_singleton()->set("_global_script_class_icons", d); @@ -988,7 +957,6 @@ void EditorData::script_class_load_icon_paths() { } EditorData::EditorData() { - current_edited_scene = -1; //load_imported_scenes_from_globals(); @@ -997,30 +965,30 @@ EditorData::EditorData() { /////////// void EditorSelection::_node_removed(Node *p_node) { - - if (!selection.has(p_node)) + if (!selection.has(p_node)) { return; + } Object *meta = selection[p_node]; - if (meta) + if (meta) { memdelete(meta); + } selection.erase(p_node); changed = true; nl_changed = true; } void EditorSelection::add_node(Node *p_node) { - ERR_FAIL_NULL(p_node); ERR_FAIL_COND(!p_node->is_inside_tree()); - if (selection.has(p_node)) + if (selection.has(p_node)) { return; + } changed = true; nl_changed = true; Object *meta = nullptr; for (List<Object *>::Element *E = editor_plugins.front(); E; E = E->next()) { - meta = E->get()->call("_get_editor_data", p_node); if (meta) { break; @@ -1034,32 +1002,31 @@ void EditorSelection::add_node(Node *p_node) { } void EditorSelection::remove_node(Node *p_node) { - ERR_FAIL_NULL(p_node); - if (!selection.has(p_node)) + if (!selection.has(p_node)) { return; + } changed = true; nl_changed = true; Object *meta = selection[p_node]; - if (meta) + if (meta) { memdelete(meta); + } selection.erase(p_node); p_node->disconnect("tree_exiting", callable_mp(this, &EditorSelection::_node_removed)); //emit_signal("selection_changed"); } -bool EditorSelection::is_selected(Node *p_node) const { +bool EditorSelection::is_selected(Node *p_node) const { return selection.has(p_node); } Array EditorSelection::_get_transformable_selected_nodes() { - Array ret; for (List<Node *>::Element *E = selected_node_list.front(); E; E = E->next()) { - ret.push_back(E->get()); } @@ -1067,11 +1034,9 @@ Array EditorSelection::_get_transformable_selected_nodes() { } TypedArray<Node> EditorSelection::get_selected_nodes() { - TypedArray<Node> ret; for (Map<Node *, Object *>::Element *E = selection.front(); E; E = E->next()) { - ret.push_back(E->key()); } @@ -1079,7 +1044,6 @@ TypedArray<Node> EditorSelection::get_selected_nodes() { } void EditorSelection::_bind_methods() { - ClassDB::bind_method(D_METHOD("clear"), &EditorSelection::clear); ClassDB::bind_method(D_METHOD("add_node", "node"), &EditorSelection::add_node); ClassDB::bind_method(D_METHOD("remove_node", "node"), &EditorSelection::remove_node); @@ -1090,19 +1054,17 @@ void EditorSelection::_bind_methods() { } void EditorSelection::add_editor_plugin(Object *p_object) { - editor_plugins.push_back(p_object); } void EditorSelection::_update_nl() { - - if (!nl_changed) + if (!nl_changed) { return; + } selected_node_list.clear(); for (Map<Node *, Object *>::Element *E = selection.front(); E; E = E->next()) { - Node *parent = E->key(); parent = parent->get_parent(); bool skip = false; @@ -1114,8 +1076,9 @@ void EditorSelection::_update_nl() { parent = parent->get_parent(); } - if (skip) + if (skip) { continue; + } selected_node_list.push_back(E->key()); } @@ -1123,11 +1086,11 @@ void EditorSelection::_update_nl() { } void EditorSelection::update() { - _update_nl(); - if (!changed) + if (!changed) { return; + } changed = false; if (!emitted) { emitted = true; @@ -1141,16 +1104,15 @@ void EditorSelection::_emit_change() { } List<Node *> &EditorSelection::get_selected_node_list() { - - if (changed) + if (changed) { update(); - else + } else { _update_nl(); + } return selected_node_list; } List<Node *> EditorSelection::get_full_selected_node_list() { - List<Node *> node_list; for (Map<Node *, Object *>::Element *E = selection.front(); E; E = E->next()) { node_list.push_back(E->key()); @@ -1160,23 +1122,20 @@ List<Node *> EditorSelection::get_full_selected_node_list() { } void EditorSelection::clear() { - while (!selection.empty()) { - remove_node(selection.front()->key()); } changed = true; nl_changed = true; } -EditorSelection::EditorSelection() { +EditorSelection::EditorSelection() { emitted = false; changed = false; nl_changed = false; } EditorSelection::~EditorSelection() { - clear(); } |