diff options
author | Tom Dobbelaere <tom.dobbelaere@student.howest.be> | 2018-03-30 18:13:19 +0200 |
---|---|---|
committer | Tom Dobbelaere <tom.dobbelaere@student.howest.be> | 2018-04-03 12:44:16 +0200 |
commit | a4fae0e5e3dd33b87aae71151e28a3c832a6fa67 (patch) | |
tree | 2fe765a13a8c0776a56ac0f645b99c5dd59eb49b /drivers/windows/file_access_windows.cpp | |
parent | c2c82a6ea27baf4faa3cb21f460a3f7814073d0d (diff) |
Trigger IO error only after exhausting attempts
Diffstat (limited to 'drivers/windows/file_access_windows.cpp')
-rw-r--r-- | drivers/windows/file_access_windows.cpp | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/drivers/windows/file_access_windows.cpp b/drivers/windows/file_access_windows.cpp index e10f4d05e8..23c8ea2ec7 100644 --- a/drivers/windows/file_access_windows.cpp +++ b/drivers/windows/file_access_windows.cpp @@ -139,19 +139,22 @@ void FileAccessWindows::close() { //atomic replace for existing file rename_error = !ReplaceFileW(save_path.c_str(), (save_path + ".tmp").c_str(), NULL, 2 | 4, NULL, NULL); } - if (rename_error && close_fail_notify) { - close_fail_notify(save_path); - } if (rename_error) { attempts--; OS::get_singleton()->delay_usec(1000000); //wait 100msec and try again } } - save_path = ""; if (rename_error) { + if (close_fail_notify) { + close_fail_notify(save_path); + } + ERR_EXPLAIN("Safe save failed. This may be a permissions problem, but also may happen because you are running a paranoid antivirus. If this is the case, please switch to Windows Defender or disable the 'safe save' option in editor settings. This makes it work, but increases the risk of file corruption in a crash."); } + + save_path = ""; + ERR_FAIL_COND(rename_error); } } |