diff options
author | Rémi Verschelde <rverschelde@gmail.com> | 2017-03-05 16:44:50 +0100 |
---|---|---|
committer | Rémi Verschelde <rverschelde@gmail.com> | 2017-03-05 16:44:50 +0100 |
commit | 5dbf1809c6e3e905b94b8764e99491e608122261 (patch) | |
tree | 5e5a5360db15d86d59ec8c6e4f7eb511388c5a9a /drivers/png | |
parent | 45438e9918d421b244bfd7776a30e67dc7f2d3e3 (diff) |
A Whole New World (clang-format edition)
I can show you the code
Pretty, with proper whitespace
Tell me, coder, now when did
You last write readable code?
I can open your eyes
Make you see your bad indent
Force you to respect the style
The core devs agreed upon
A whole new world
A new fantastic code format
A de facto standard
With some sugar
Enforced with clang-format
A whole new world
A dazzling style we all dreamed of
And when we read it through
It's crystal clear
That now we're in a whole new world of code
Diffstat (limited to 'drivers/png')
-rw-r--r-- | drivers/png/image_loader_png.cpp | 212 | ||||
-rw-r--r-- | drivers/png/image_loader_png.h | 14 | ||||
-rw-r--r-- | drivers/png/resource_saver_png.cpp | 106 | ||||
-rw-r--r-- | drivers/png/resource_saver_png.h | 10 |
4 files changed, 150 insertions, 192 deletions
diff --git a/drivers/png/image_loader_png.cpp b/drivers/png/image_loader_png.cpp index 51429f3416..c524bee43c 100644 --- a/drivers/png/image_loader_png.cpp +++ b/drivers/png/image_loader_png.cpp @@ -28,16 +28,15 @@ /*************************************************************************/ #include "image_loader_png.h" -#include "print_string.h" #include "os/os.h" +#include "print_string.h" #include <string.h> +void ImageLoaderPNG::_read_png_data(png_structp png_ptr, png_bytep data, png_size_t p_length) { -void ImageLoaderPNG::_read_png_data(png_structp png_ptr,png_bytep data, png_size_t p_length) { - - FileAccess *f = (FileAccess*)png_get_io_ptr(png_ptr); - f->get_buffer( (uint8_t*)data, p_length ); + FileAccess *f = (FileAccess *)png_get_io_ptr(png_ptr); + f->get_buffer((uint8_t *)data, p_length); } /* @@ -51,7 +50,7 @@ static png_voidp _png_malloc_fn(png_structp png_ptr, png_size_t size) { return memalloc(size); } -static void _png_free_fn(png_structp png_ptr, png_voidp ptr) { +static void _png_free_fn(png_structp png_ptr, png_voidp ptr) { memfree(ptr); } @@ -66,42 +65,39 @@ static void _png_warn_function(png_structp, png_const_charp text) { WARN_PRINT(text); } -typedef void (PNGAPI *png_error_ptr) PNGARG((png_structp, png_const_charp)); - -Error ImageLoaderPNG::_load_image(void *rf_up,png_rw_ptr p_func,Image *p_image) { - +typedef void(PNGAPI *png_error_ptr) PNGARG((png_structp, png_const_charp)); +Error ImageLoaderPNG::_load_image(void *rf_up, png_rw_ptr p_func, Image *p_image) { png_structp png; png_infop info; //png = png_create_read_struct(PNG_LIBPNG_VER_STRING, (png_voidp)NULL, NULL, NULL); - png = png_create_read_struct_2(PNG_LIBPNG_VER_STRING, (png_voidp)NULL,_png_error_function,_png_warn_function,(png_voidp)NULL, - _png_malloc_fn,_png_free_fn ); + png = png_create_read_struct_2(PNG_LIBPNG_VER_STRING, (png_voidp)NULL, _png_error_function, _png_warn_function, (png_voidp)NULL, + _png_malloc_fn, _png_free_fn); ERR_FAIL_COND_V(!png, ERR_OUT_OF_MEMORY); info = png_create_info_struct(png); if (!info) { - png_destroy_read_struct(&png,NULL,NULL); + png_destroy_read_struct(&png, NULL, NULL); ERR_PRINT("Out of Memory"); return ERR_OUT_OF_MEMORY; } if (setjmp(png_jmpbuf(png))) { - png_destroy_read_struct(&png,NULL,NULL); - ERR_PRINT("PNG Corrupted"); - return ERR_FILE_CORRUPT; + png_destroy_read_struct(&png, NULL, NULL); + ERR_PRINT("PNG Corrupted"); + return ERR_FILE_CORRUPT; } - png_set_read_fn(png,(void*)rf_up,p_func); + png_set_read_fn(png, (void *)rf_up, p_func); png_uint_32 width, height; int depth, color; - png_read_info(png, info); png_get_IHDR(png, info, &width, &height, &depth, &color, NULL, NULL, NULL); @@ -114,29 +110,28 @@ Error ImageLoaderPNG::_load_image(void *rf_up,png_rw_ptr p_func,Image *p_image) printf("Color type:%i\n", color); */ - bool update_info=false; + bool update_info = false; - if (depth<8) { //only bit dept 8 per channel is handled + if (depth < 8) { //only bit dept 8 per channel is handled png_set_packing(png); - update_info=true; - + update_info = true; }; - if (png_get_color_type(png,info)==PNG_COLOR_TYPE_PALETTE) { + if (png_get_color_type(png, info) == PNG_COLOR_TYPE_PALETTE) { png_set_palette_to_rgb(png); - update_info=true; + update_info = true; } if (depth > 8) { png_set_strip_16(png); - update_info=true; + update_info = true; } - if (png_get_valid(png,info,PNG_INFO_tRNS)) { + if (png_get_valid(png, info, PNG_INFO_tRNS)) { //png_set_expand_gray_1_2_4_to_8(png); png_set_tRNS_to_alpha(png); - update_info=true; + update_info = true; } if (update_info) { @@ -147,29 +142,28 @@ Error ImageLoaderPNG::_load_image(void *rf_up,png_rw_ptr p_func,Image *p_image) int components = 0; Image::Format fmt; - switch(color) { - + switch (color) { case PNG_COLOR_TYPE_GRAY: { - fmt=Image::FORMAT_L8; - components=1; + fmt = Image::FORMAT_L8; + components = 1; } break; case PNG_COLOR_TYPE_GRAY_ALPHA: { - fmt=Image::FORMAT_LA8; - components=2; + fmt = Image::FORMAT_LA8; + components = 2; } break; case PNG_COLOR_TYPE_RGB: { - fmt=Image::FORMAT_RGB8; - components=3; + fmt = Image::FORMAT_RGB8; + components = 3; } break; case PNG_COLOR_TYPE_RGB_ALPHA: { - fmt=Image::FORMAT_RGBA8; - components=4; - } break; + fmt = Image::FORMAT_RGBA8; + components = 4; + } break; default: { ERR_PRINT("INVALID PNG TYPE"); @@ -183,39 +177,35 @@ Error ImageLoaderPNG::_load_image(void *rf_up,png_rw_ptr p_func,Image *p_image) PoolVector<uint8_t> dstbuff; - dstbuff.resize( rowsize * height ); + dstbuff.resize(rowsize * height); PoolVector<uint8_t>::Write dstbuff_write = dstbuff.write(); - uint8_t* data = dstbuff_write.ptr(); + uint8_t *data = dstbuff_write.ptr(); - uint8_t **row_p = memnew_arr( uint8_t*, height ); + uint8_t **row_p = memnew_arr(uint8_t *, height); for (unsigned int i = 0; i < height; i++) { - row_p[i] = &data[components*width*i]; + row_p[i] = &data[components * width * i]; } - png_read_image(png, (png_bytep*)row_p); - + png_read_image(png, (png_bytep *)row_p); - memdelete_arr( row_p ); + memdelete_arr(row_p); - p_image->create( width, height, 0,fmt, dstbuff ); + p_image->create(width, height, 0, fmt, dstbuff); - png_destroy_read_struct(&png, &info, NULL ); + png_destroy_read_struct(&png, &info, NULL); return OK; } +Error ImageLoaderPNG::load_image(Image *p_image, FileAccess *f) { -Error ImageLoaderPNG::load_image(Image *p_image,FileAccess *f) { - - Error err = _load_image(f,_read_png_data,p_image); + Error err = _load_image(f, _read_png_data, p_image); f->close(); - return err; - } void ImageLoaderPNG::get_recognized_extensions(List<String> *p_extensions) const { @@ -223,7 +213,6 @@ void ImageLoaderPNG::get_recognized_extensions(List<String> *p_extensions) const p_extensions->push_back("png"); } - struct PNGReadStatus { int offset; @@ -231,84 +220,76 @@ struct PNGReadStatus { const unsigned char *image; }; -static void user_read_data(png_structp png_ptr,png_bytep data, png_size_t p_length) { +static void user_read_data(png_structp png_ptr, png_bytep data, png_size_t p_length) { PNGReadStatus *rstatus; - rstatus=(PNGReadStatus*)png_get_io_ptr(png_ptr); + rstatus = (PNGReadStatus *)png_get_io_ptr(png_ptr); - png_size_t to_read=p_length; - if (rstatus->size>=0) { - to_read = MIN( p_length, rstatus->size - rstatus->offset); + png_size_t to_read = p_length; + if (rstatus->size >= 0) { + to_read = MIN(p_length, rstatus->size - rstatus->offset); } - memcpy(data,&rstatus->image[rstatus->offset],to_read); - rstatus->offset+=to_read; + memcpy(data, &rstatus->image[rstatus->offset], to_read); + rstatus->offset += to_read; - if (to_read<p_length) { - memset(&data[to_read],0,p_length-to_read); + if (to_read < p_length) { + memset(&data[to_read], 0, p_length - to_read); } } - -static Image _load_mem_png(const uint8_t* p_png,int p_size) { - +static Image _load_mem_png(const uint8_t *p_png, int p_size) { PNGReadStatus prs; - prs.image=p_png; - prs.offset=0; - prs.size=p_size; + prs.image = p_png; + prs.offset = 0; + prs.size = p_size; Image img; - Error err = ImageLoaderPNG::_load_image(&prs,user_read_data,&img); - ERR_FAIL_COND_V(err,Image()); + Error err = ImageLoaderPNG::_load_image(&prs, user_read_data, &img); + ERR_FAIL_COND_V(err, Image()); return img; } - -static Image _lossless_unpack_png(const PoolVector<uint8_t>& p_data) { +static Image _lossless_unpack_png(const PoolVector<uint8_t> &p_data) { int len = p_data.size(); PoolVector<uint8_t>::Read r = p_data.read(); - ERR_FAIL_COND_V(r[0]!='P' || r[1]!='N' || r[2]!='G' || r[3]!=' ',Image()); - return _load_mem_png(&r[4],len-4); - + ERR_FAIL_COND_V(r[0] != 'P' || r[1] != 'N' || r[2] != 'G' || r[3] != ' ', Image()); + return _load_mem_png(&r[4], len - 4); } -static void _write_png_data(png_structp png_ptr,png_bytep data, png_size_t p_length) { +static void _write_png_data(png_structp png_ptr, png_bytep data, png_size_t p_length) { - PoolVector<uint8_t> &v = *(PoolVector<uint8_t>*)png_get_io_ptr(png_ptr); + PoolVector<uint8_t> &v = *(PoolVector<uint8_t> *)png_get_io_ptr(png_ptr); int vs = v.size(); - v.resize(vs+p_length); + v.resize(vs + p_length); PoolVector<uint8_t>::Write w = v.write(); - copymem(&w[vs],data,p_length); + copymem(&w[vs], data, p_length); //print_line("png write: "+itos(p_length)); } - -static PoolVector<uint8_t> _lossless_pack_png(const Image& p_image) { - +static PoolVector<uint8_t> _lossless_pack_png(const Image &p_image) { Image img = p_image; if (img.is_compressed()) img.decompress(); - ERR_FAIL_COND_V(img.is_compressed(), PoolVector<uint8_t>()); png_structp png_ptr; png_infop info_ptr; - png_bytep * row_pointers; - + png_bytep *row_pointers; /* initialize stuff */ png_ptr = png_create_write_struct(PNG_LIBPNG_VER_STRING, NULL, NULL, NULL); - ERR_FAIL_COND_V(!png_ptr,PoolVector<uint8_t>()); + ERR_FAIL_COND_V(!png_ptr, PoolVector<uint8_t>()); info_ptr = png_create_info_struct(png_ptr); - ERR_FAIL_COND_V(!info_ptr,PoolVector<uint8_t>()); + ERR_FAIL_COND_V(!info_ptr, PoolVector<uint8_t>()); if (setjmp(png_jmpbuf(png_ptr))) { ERR_FAIL_V(PoolVector<uint8_t>()); @@ -319,76 +300,73 @@ static PoolVector<uint8_t> _lossless_pack_png(const Image& p_image) { ret.push_back('G'); ret.push_back(' '); - png_set_write_fn(png_ptr,&ret,_write_png_data,NULL); + png_set_write_fn(png_ptr, &ret, _write_png_data, NULL); /* write header */ if (setjmp(png_jmpbuf(png_ptr))) { ERR_FAIL_V(PoolVector<uint8_t>()); } - int pngf=0; - int cs=0; + int pngf = 0; + int cs = 0; - switch(img.get_format()) { + switch (img.get_format()) { case Image::FORMAT_L8: { - pngf=PNG_COLOR_TYPE_GRAY; - cs=1; + pngf = PNG_COLOR_TYPE_GRAY; + cs = 1; } break; case Image::FORMAT_LA8: { - pngf=PNG_COLOR_TYPE_GRAY_ALPHA; - cs=2; + pngf = PNG_COLOR_TYPE_GRAY_ALPHA; + cs = 2; } break; case Image::FORMAT_RGB8: { - pngf=PNG_COLOR_TYPE_RGB; - cs=3; + pngf = PNG_COLOR_TYPE_RGB; + cs = 3; } break; case Image::FORMAT_RGBA8: { - pngf=PNG_COLOR_TYPE_RGB_ALPHA; - cs=4; + pngf = PNG_COLOR_TYPE_RGB_ALPHA; + cs = 4; } break; default: { if (img.detect_alpha()) { img.convert(Image::FORMAT_RGBA8); - pngf=PNG_COLOR_TYPE_RGB_ALPHA; - cs=4; + pngf = PNG_COLOR_TYPE_RGB_ALPHA; + cs = 4; } else { img.convert(Image::FORMAT_RGB8); - pngf=PNG_COLOR_TYPE_RGB; - cs=3; + pngf = PNG_COLOR_TYPE_RGB; + cs = 3; } - } } int w = img.get_width(); int h = img.get_height(); - png_set_IHDR(png_ptr, info_ptr, w,h, - 8, pngf, PNG_INTERLACE_NONE, - PNG_COMPRESSION_TYPE_BASE, PNG_FILTER_TYPE_BASE); + png_set_IHDR(png_ptr, info_ptr, w, h, + 8, pngf, PNG_INTERLACE_NONE, + PNG_COMPRESSION_TYPE_BASE, PNG_FILTER_TYPE_BASE); png_write_info(png_ptr, info_ptr); - /* write bytes */ if (setjmp(png_jmpbuf(png_ptr))) { ERR_FAIL_V(PoolVector<uint8_t>()); } - PoolVector<uint8_t>::Read r = img.get_data().read(); - row_pointers = (png_bytep*)memalloc(sizeof(png_bytep)*h); - for(int i=0;i<h;i++) { + row_pointers = (png_bytep *)memalloc(sizeof(png_bytep) * h); + for (int i = 0; i < h; i++) { - row_pointers[i]=(png_bytep)&r[i*w*cs]; + row_pointers[i] = (png_bytep)&r[i * w * cs]; } png_write_image(png_ptr, row_pointers); @@ -402,16 +380,12 @@ static PoolVector<uint8_t> _lossless_pack_png(const Image& p_image) { png_write_end(png_ptr, NULL); - return ret; } ImageLoaderPNG::ImageLoaderPNG() { - - Image::_png_mem_loader_func=_load_mem_png; - Image::lossless_unpacker=_lossless_unpack_png; - Image::lossless_packer=_lossless_pack_png; - - + Image::_png_mem_loader_func = _load_mem_png; + Image::lossless_unpacker = _lossless_unpack_png; + Image::lossless_packer = _lossless_pack_png; } diff --git a/drivers/png/image_loader_png.h b/drivers/png/image_loader_png.h index a98ad513db..00a64c5537 100644 --- a/drivers/png/image_loader_png.h +++ b/drivers/png/image_loader_png.h @@ -38,19 +38,13 @@ */ class ImageLoaderPNG : public ImageFormatLoader { - static void _read_png_data(png_structp png_ptr,png_bytep data, png_size_t p_length); - - + static void _read_png_data(png_structp png_ptr, png_bytep data, png_size_t p_length); public: - - - static Error _load_image(void *rf_up,png_rw_ptr p_func,Image *p_image); - virtual Error load_image(Image *p_image,FileAccess *f); - virtual void get_recognized_extensions(List<String> *p_extensions) const; + static Error _load_image(void *rf_up, png_rw_ptr p_func, Image *p_image); + virtual Error load_image(Image *p_image, FileAccess *f); + virtual void get_recognized_extensions(List<String> *p_extensions) const; ImageLoaderPNG(); }; - - #endif diff --git a/drivers/png/resource_saver_png.cpp b/drivers/png/resource_saver_png.cpp index f55b089ded..ce1ffde1c8 100644 --- a/drivers/png/resource_saver_png.cpp +++ b/drivers/png/resource_saver_png.cpp @@ -35,20 +35,19 @@ #include <png.h> -static void _write_png_data(png_structp png_ptr,png_bytep data, png_size_t p_length) { +static void _write_png_data(png_structp png_ptr, png_bytep data, png_size_t p_length) { - FileAccess *f = (FileAccess*)png_get_io_ptr(png_ptr); - f->store_buffer( (const uint8_t*)data,p_length); + FileAccess *f = (FileAccess *)png_get_io_ptr(png_ptr); + f->store_buffer((const uint8_t *)data, p_length); } -Error ResourceSaverPNG::save(const String &p_path,const RES& p_resource,uint32_t p_flags) { +Error ResourceSaverPNG::save(const String &p_path, const RES &p_resource, uint32_t p_flags) { - Ref<ImageTexture> texture=p_resource; + Ref<ImageTexture> texture = p_resource; - ERR_FAIL_COND_V(!texture.is_valid(),ERR_INVALID_PARAMETER); + ERR_FAIL_COND_V(!texture.is_valid(), ERR_INVALID_PARAMETER); ERR_EXPLAIN("Can't save empty texture as PNG"); - ERR_FAIL_COND_V(!texture->get_width() || !texture->get_height(),ERR_INVALID_PARAMETER); - + ERR_FAIL_COND_V(!texture->get_width() || !texture->get_height(), ERR_INVALID_PARAMETER); Image img = texture->get_data(); @@ -62,28 +61,28 @@ Error ResourceSaverPNG::save(const String &p_path,const RES& p_resource,uint32_t String text; - if (global_filter!=bool(texture->get_flags()&Texture::FLAG_FILTER)) { - text+=bool(texture->get_flags()&Texture::FLAG_FILTER)?"filter=true\n":"filter=false\n"; + if (global_filter != bool(texture->get_flags() & Texture::FLAG_FILTER)) { + text += bool(texture->get_flags() & Texture::FLAG_FILTER) ? "filter=true\n" : "filter=false\n"; } - if (global_mipmaps!=bool(texture->get_flags()&Texture::FLAG_MIPMAPS)) { - text+=bool(texture->get_flags()&Texture::FLAG_MIPMAPS)?"gen_mipmaps=true\n":"gen_mipmaps=false\n"; + if (global_mipmaps != bool(texture->get_flags() & Texture::FLAG_MIPMAPS)) { + text += bool(texture->get_flags() & Texture::FLAG_MIPMAPS) ? "gen_mipmaps=true\n" : "gen_mipmaps=false\n"; } - if (global_repeat!=bool(texture->get_flags()&Texture::FLAG_REPEAT)) { - text+=bool(texture->get_flags()&Texture::FLAG_REPEAT)?"repeat=true\n":"repeat=false\n"; + if (global_repeat != bool(texture->get_flags() & Texture::FLAG_REPEAT)) { + text += bool(texture->get_flags() & Texture::FLAG_REPEAT) ? "repeat=true\n" : "repeat=false\n"; } - if (bool(texture->get_flags()&Texture::FLAG_ANISOTROPIC_FILTER)) { - text+="anisotropic=true\n"; + if (bool(texture->get_flags() & Texture::FLAG_ANISOTROPIC_FILTER)) { + text += "anisotropic=true\n"; } - if (bool(texture->get_flags()&Texture::FLAG_CONVERT_TO_LINEAR)) { - text+="tolinear=true\n"; + if (bool(texture->get_flags() & Texture::FLAG_CONVERT_TO_LINEAR)) { + text += "tolinear=true\n"; } - if (bool(texture->get_flags()&Texture::FLAG_MIRRORED_REPEAT)) { - text+="mirroredrepeat=true\n"; + if (bool(texture->get_flags() & Texture::FLAG_MIRRORED_REPEAT)) { + text += "mirroredrepeat=true\n"; } - if (text!="" || FileAccess::exists(p_path+".flags")) { + if (text != "" || FileAccess::exists(p_path + ".flags")) { - FileAccess* f = FileAccess::open(p_path+".flags",FileAccess::WRITE); + FileAccess *f = FileAccess::open(p_path + ".flags", FileAccess::WRITE); if (f) { f->store_string(text); @@ -92,7 +91,6 @@ Error ResourceSaverPNG::save(const String &p_path,const RES& p_resource,uint32_t } } - return err; }; @@ -105,100 +103,95 @@ Error ResourceSaverPNG::save_image(const String &p_path, Image &p_img) { png_structp png_ptr; png_infop info_ptr; - png_bytep * row_pointers; - + png_bytep *row_pointers; /* initialize stuff */ png_ptr = png_create_write_struct(PNG_LIBPNG_VER_STRING, NULL, NULL, NULL); - ERR_FAIL_COND_V(!png_ptr,ERR_CANT_CREATE); + ERR_FAIL_COND_V(!png_ptr, ERR_CANT_CREATE); info_ptr = png_create_info_struct(png_ptr); - ERR_FAIL_COND_V(!info_ptr,ERR_CANT_CREATE); + ERR_FAIL_COND_V(!info_ptr, ERR_CANT_CREATE); if (setjmp(png_jmpbuf(png_ptr))) { ERR_FAIL_V(ERR_CANT_OPEN); } //change this Error err; - FileAccess* f = FileAccess::open(p_path,FileAccess::WRITE,&err); + FileAccess *f = FileAccess::open(p_path, FileAccess::WRITE, &err); if (err) { ERR_FAIL_V(err); } - png_set_write_fn(png_ptr,f,_write_png_data,NULL); + png_set_write_fn(png_ptr, f, _write_png_data, NULL); /* write header */ if (setjmp(png_jmpbuf(png_ptr))) { ERR_FAIL_V(ERR_CANT_OPEN); } - int pngf=0; - int cs=0; - + int pngf = 0; + int cs = 0; - switch(p_img.get_format()) { + switch (p_img.get_format()) { case Image::FORMAT_L8: { - pngf=PNG_COLOR_TYPE_GRAY; - cs=1; + pngf = PNG_COLOR_TYPE_GRAY; + cs = 1; } break; case Image::FORMAT_LA8: { - pngf=PNG_COLOR_TYPE_GRAY_ALPHA; - cs=2; + pngf = PNG_COLOR_TYPE_GRAY_ALPHA; + cs = 2; } break; case Image::FORMAT_RGB8: { - pngf=PNG_COLOR_TYPE_RGB; - cs=3; + pngf = PNG_COLOR_TYPE_RGB; + cs = 3; } break; case Image::FORMAT_RGBA8: { - pngf=PNG_COLOR_TYPE_RGB_ALPHA; - cs=4; + pngf = PNG_COLOR_TYPE_RGB_ALPHA; + cs = 4; } break; default: { if (p_img.detect_alpha()) { p_img.convert(Image::FORMAT_RGBA8); - pngf=PNG_COLOR_TYPE_RGB_ALPHA; - cs=4; + pngf = PNG_COLOR_TYPE_RGB_ALPHA; + cs = 4; } else { p_img.convert(Image::FORMAT_RGB8); - pngf=PNG_COLOR_TYPE_RGB; - cs=3; + pngf = PNG_COLOR_TYPE_RGB; + cs = 3; } - } } int w = p_img.get_width(); int h = p_img.get_height(); - png_set_IHDR(png_ptr, info_ptr, w,h, - 8, pngf, PNG_INTERLACE_NONE, - PNG_COMPRESSION_TYPE_BASE, PNG_FILTER_TYPE_BASE); + png_set_IHDR(png_ptr, info_ptr, w, h, + 8, pngf, PNG_INTERLACE_NONE, + PNG_COMPRESSION_TYPE_BASE, PNG_FILTER_TYPE_BASE); png_write_info(png_ptr, info_ptr); - /* write bytes */ if (setjmp(png_jmpbuf(png_ptr))) { memdelete(f); ERR_FAIL_V(ERR_CANT_OPEN); } - PoolVector<uint8_t>::Read r = p_img.get_data().read(); - row_pointers = (png_bytep*)memalloc(sizeof(png_bytep)*h); - for(int i=0;i<h;i++) { + row_pointers = (png_bytep *)memalloc(sizeof(png_bytep) * h); + for (int i = 0; i < h; i++) { - row_pointers[i]=(png_bytep)&r[i*w*cs]; + row_pointers[i] = (png_bytep)&r[i * w * cs]; } png_write_image(png_ptr, row_pointers); @@ -220,16 +213,15 @@ Error ResourceSaverPNG::save_image(const String &p_path, Image &p_img) { return OK; } -bool ResourceSaverPNG::recognize(const RES& p_resource) const { +bool ResourceSaverPNG::recognize(const RES &p_resource) const { return (p_resource.is_valid() && p_resource->is_class("ImageTexture")); } -void ResourceSaverPNG::get_recognized_extensions(const RES& p_resource,List<String> *p_extensions) const{ +void ResourceSaverPNG::get_recognized_extensions(const RES &p_resource, List<String> *p_extensions) const { if (p_resource->cast_to<Texture>()) { p_extensions->push_back("png"); } - } ResourceSaverPNG::ResourceSaverPNG() { diff --git a/drivers/png/resource_saver_png.h b/drivers/png/resource_saver_png.h index c71877d728..ebc8d8e3ae 100644 --- a/drivers/png/resource_saver_png.h +++ b/drivers/png/resource_saver_png.h @@ -33,15 +33,13 @@ class ResourceSaverPNG : public ResourceFormatSaver { public: + static Error save_image(const String &p_path, Image &p_img); - static Error save_image(const String &p_path, Image& p_img); - - virtual Error save(const String &p_path,const RES& p_resource,uint32_t p_flags=0); - virtual bool recognize(const RES& p_resource) const; - virtual void get_recognized_extensions(const RES& p_resource,List<String> *p_extensions) const; + virtual Error save(const String &p_path, const RES &p_resource, uint32_t p_flags = 0); + virtual bool recognize(const RES &p_resource) const; + virtual void get_recognized_extensions(const RES &p_resource, List<String> *p_extensions) const; ResourceSaverPNG(); }; - #endif // RESOURCE_SAVER_PNG_H |