diff options
author | RĂ©mi Verschelde <remi@verschelde.fr> | 2022-03-15 20:26:18 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-03-15 20:26:18 +0100 |
commit | fb28025785082f5e2f523af83e56219f308c3d6d (patch) | |
tree | 389e742995ae6cadc9a1972a9a2e66ddeaffd77b /core | |
parent | 41edfc88a3f82e643ad3f4613de7a787a00ee68a (diff) | |
parent | 38995961dfbbd656f038e107fca75d94a71aa81a (diff) |
Merge pull request #59153 from Calinou/debug-stringnames-improve
Improve `--debug-stringnames` to be more useful
Diffstat (limited to 'core')
-rw-r--r-- | core/string/string_name.cpp | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/core/string/string_name.cpp b/core/string/string_name.cpp index 11674629fc..2e941b8037 100644 --- a/core/string/string_name.cpp +++ b/core/string/string_name.cpp @@ -73,11 +73,23 @@ void StringName::cleanup() { d = d->next; } } - print_line("\nStringName Reference Ranking:\n"); + + print_line("\nStringName reference ranking (from most to least referenced):\n"); + data.sort_custom<DebugSortReferences>(); - for (int i = 0; i < MIN(100, data.size()); i++) { + int unreferenced_stringnames = 0; + int rarely_referenced_stringnames = 0; + for (int i = 0; i < data.size(); i++) { print_line(itos(i + 1) + ": " + data[i]->get_name() + " - " + itos(data[i]->debug_references)); + if (data[i]->debug_references == 0) { + unreferenced_stringnames += 1; + } else if (data[i]->debug_references < 5) { + rarely_referenced_stringnames += 1; + } } + + print_line(vformat("\nOut of %d StringNames, %d StringNames were never referenced during this run (0 times) (%.2f%%).", data.size(), unreferenced_stringnames, unreferenced_stringnames / float(data.size()) * 100)); + print_line(vformat("Out of %d StringNames, %d StringNames were rarely referenced during this run (1-4 times) (%.2f%%).", data.size(), rarely_referenced_stringnames, rarely_referenced_stringnames / float(data.size()) * 100)); } #endif int lost_strings = 0; |