summaryrefslogtreecommitdiff
path: root/core
diff options
context:
space:
mode:
authorMaganty Rushyendra <mrushyendra@yahoo.com.sg>2020-12-31 18:33:39 +0800
committerMaganty Rushyendra <mrushyendra@yahoo.com.sg>2021-01-01 13:08:10 +0800
commit6c026a6814eb15c2832f9cfd30ee8ef8d0a236ab (patch)
treee6242f8f134e2df388deeff5520a34da525a369e /core
parent36c943260ed40c6e31a6ecff7f6e1674714b4fcb (diff)
Issue more precise error when disconnecting a nonexistent connection
Checks whether the signal exists when issuing an error message when disconnecting a nonexistent connection. Also prints the callable name.
Diffstat (limited to 'core')
-rw-r--r--core/object/object.cpp7
1 files changed, 6 insertions, 1 deletions
diff --git a/core/object/object.cpp b/core/object/object.cpp
index a53925f990..2e05119f35 100644
--- a/core/object/object.cpp
+++ b/core/object/object.cpp
@@ -1357,7 +1357,12 @@ void Object::_disconnect(const StringName &p_signal, const Callable &p_callable,
ERR_FAIL_COND(!target_object);
SignalData *s = signal_map.getptr(p_signal);
- ERR_FAIL_COND_MSG(!s, vformat("Nonexistent signal '%s' in %s.", p_signal, to_string()));
+ if (!s) {
+ bool signal_is_valid = ClassDB::has_signal(get_class_name(), p_signal) ||
+ (!script.is_null() && Ref<Script>(script)->has_script_signal(p_signal));
+ ERR_FAIL_COND_MSG(signal_is_valid, "Attempt to disconnect a nonexistent connection from '" + to_string() + "'. signal: '" + p_signal + "', callable: '" + p_callable + "'.");
+ }
+ ERR_FAIL_COND_MSG(!s, vformat("Disconnecting nonexistent signal '%s' in %s.", p_signal, to_string()));
ERR_FAIL_COND_MSG(!s->slot_map.has(*p_callable.get_base_comparator()), "Disconnecting nonexistent signal '" + p_signal + "', callable: " + p_callable + ".");