summaryrefslogtreecommitdiff
path: root/core/os
diff options
context:
space:
mode:
authorvoidshine <skylark@nightshade>2022-09-17 11:29:41 -0700
committervoidshine <voidshine@outlook.com>2022-10-11 12:40:28 -0700
commitf0f72b313236b3cd8793e6fe7487094d9a04694a (patch)
tree36698b62807156a733a489764a092f94d0edb9e3 /core/os
parent4ab3fdcda07bf700b33eb7c85f53826b2464c02f (diff)
Fix MIDI note-on events being converted to note-off events
Update documentation with note about MIDI velocity interpretation
Diffstat (limited to 'core/os')
-rw-r--r--core/os/midi_driver.cpp5
1 files changed, 0 insertions, 5 deletions
diff --git a/core/os/midi_driver.cpp b/core/os/midi_driver.cpp
index 410b62068a..79eef95ef2 100644
--- a/core/os/midi_driver.cpp
+++ b/core/os/midi_driver.cpp
@@ -86,11 +86,6 @@ void MIDIDriver::receive_input_packet(uint64_t timestamp, uint8_t *data, uint32_
if (length >= 2 + param_position) {
event->set_pitch(data[param_position]);
event->set_velocity(data[param_position + 1]);
-
- if (event->get_message() == MIDIMessage::NOTE_ON && event->get_velocity() == 0) {
- // https://www.midi.org/forum/228-writing-midi-software-send-note-off,-or-zero-velocity-note-on
- event->set_message(MIDIMessage::NOTE_OFF);
- }
}
break;