summaryrefslogtreecommitdiff
path: root/core/object
diff options
context:
space:
mode:
authorJuan Linietsky <reduzio@gmail.com>2023-01-10 13:08:10 +0100
committerJuan Linietsky <reduzio@gmail.com>2023-01-10 13:56:27 +0100
commit33d3b7eea77517cd2fcce59c5e9128aa74511f9f (patch)
tree7e6eebb865de9b2a38589379644e557bf448577f /core/object
parent91713ced81792b10fdc9367b7f355738e5d52777 (diff)
Fix Callable call error reporting.
* Fix potential crash when using bind in `Variant::get_callable_error_text()` * Properly compute bound arguments so they can be properly shown. * Add a function to obtain the actual bound arguments.
Diffstat (limited to 'core/object')
-rw-r--r--core/object/object.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/core/object/object.cpp b/core/object/object.cpp
index 1f0a7e516d..2cb56dfe6c 100644
--- a/core/object/object.cpp
+++ b/core/object/object.cpp
@@ -1055,7 +1055,7 @@ Error Object::emit_signalp(const StringName &p_name, const Variant **p_args, int
if (ce.error == Callable::CallError::CALL_ERROR_INVALID_METHOD && !ClassDB::class_exists(target->get_class_name())) {
//most likely object is not initialized yet, do not throw error.
} else {
- ERR_PRINT("Error calling from signal '" + String(p_name) + "' to callable: " + Variant::get_callable_error_text(c.callable, args, argc + c.callable.get_bound_arguments_count(), ce) + ".");
+ ERR_PRINT("Error calling from signal '" + String(p_name) + "' to callable: " + Variant::get_callable_error_text(c.callable, args, argc, ce) + ".");
err = ERR_METHOD_NOT_FOUND;
}
}