diff options
| author | Max Hilbrunner <mhilbrunner@users.noreply.github.com> | 2021-12-02 14:41:02 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-02 14:41:02 +0100 |
| commit | 837e6bdf1859d2054b31730fb71c636f681300da (patch) | |
| tree | 0f1c43a76928b485b16f15b05967cd05930e99d6 /core/math/rect2.cpp | |
| parent | 1b661232074d910000b48bcdec2a7df97e1e4ea7 (diff) | |
| parent | 9687f6fca34813ec6e63029244a95caf6b793a45 (diff) | |
Merge pull request #37626 from aaronfranke/rect2-warnings
Print warnings when using a Rect2 or AABB with a negative size
Diffstat (limited to 'core/math/rect2.cpp')
| -rw-r--r-- | core/math/rect2.cpp | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/core/math/rect2.cpp b/core/math/rect2.cpp index f64bf560c8..0e6127b017 100644 --- a/core/math/rect2.cpp +++ b/core/math/rect2.cpp @@ -35,6 +35,11 @@ bool Rect2::is_equal_approx(const Rect2 &p_rect) const { } bool Rect2::intersects_segment(const Point2 &p_from, const Point2 &p_to, Point2 *r_pos, Point2 *r_normal) const { +#ifdef MATH_CHECKS + if (unlikely(size.x < 0 || size.y < 0)) { + ERR_PRINT("Rect2 size is negative, this is not supported. Use Rect2.abs() to get a Rect2 with a positive size."); + } +#endif real_t min = 0, max = 1; int axis = 0; real_t sign = 0; @@ -95,6 +100,11 @@ bool Rect2::intersects_segment(const Point2 &p_from, const Point2 &p_to, Point2 } bool Rect2::intersects_transformed(const Transform2D &p_xform, const Rect2 &p_rect) const { +#ifdef MATH_CHECKS + if (unlikely(size.x < 0 || size.y < 0 || p_rect.size.x < 0 || p_rect.size.y < 0)) { + ERR_PRINT("Rect2 size is negative, this is not supported. Use Rect2.abs() to get a Rect2 with a positive size."); + } +#endif //SAT intersection between local and transformed rect2 Vector2 xf_points[4] = { |