diff options
| author | marxin <mliska@suse.cz> | 2019-02-21 20:57:39 +0100 |
|---|---|---|
| committer | marxin <mliska@suse.cz> | 2019-02-27 07:45:57 +0100 |
| commit | e5f665c7187b6934a71169cab5075f899150f17a (patch) | |
| tree | a42da38f0076409975980452e8264a60d94f747d /core/io | |
| parent | ce114e35dda4b3f282abb458f8409db2369b279e (diff) | |
Fix -Wsign-compare warnings.
I decided to modify code in a defensive way. Ideally functions
like size() or length() should return an unsigned type.
Diffstat (limited to 'core/io')
| -rw-r--r-- | core/io/packet_peer.cpp | 2 | ||||
| -rw-r--r-- | core/io/resource_format_binary.cpp | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/core/io/packet_peer.cpp b/core/io/packet_peer.cpp index 3aa1fcfd8f..d7bfdbbb37 100644 --- a/core/io/packet_peer.cpp +++ b/core/io/packet_peer.cpp @@ -224,7 +224,7 @@ Error PacketPeerStream::get_packet(const uint8_t **r_buffer, int &r_buffer_size) uint32_t len = decode_uint32(lbuf); ERR_FAIL_COND_V(remaining < (int)len, ERR_UNAVAILABLE); - ERR_FAIL_COND_V(input_buffer.size() < len, ERR_UNAVAILABLE); + ERR_FAIL_COND_V(input_buffer.size() < (int)len, ERR_UNAVAILABLE); ring_buffer.read(lbuf, 4); //get rid of first 4 bytes ring_buffer.read(input_buffer.ptrw(), len); // read packet diff --git a/core/io/resource_format_binary.cpp b/core/io/resource_format_binary.cpp index 6c48942d72..42070cd132 100644 --- a/core/io/resource_format_binary.cpp +++ b/core/io/resource_format_binary.cpp @@ -106,7 +106,7 @@ StringName ResourceInteractiveLoaderBinary::_get_string() { uint32_t id = f->get_32(); if (id & 0x80000000) { uint32_t len = id & 0x7FFFFFFF; - if (len > str_buf.size()) { + if ((int)len > str_buf.size()) { str_buf.resize(len); } if (len == 0) |