diff options
author | Eric M <itsjusteza@gmail.com> | 2023-01-13 21:36:44 +1000 |
---|---|---|
committer | Eric M <itsjusteza@gmail.com> | 2023-01-13 21:48:43 +1000 |
commit | 7c73b6c71cad819cd7c53c8ccf14f7e909203c0d (patch) | |
tree | b7576b8970eacd19681730a8fdd605935472c0d6 /core/config | |
parent | 3c9bf4bc210a8e6a208f30ca59de4d4d7e18c04d (diff) |
Fix Project Settings array/dicts initial value being shared instances of the current value.
Diffstat (limited to 'core/config')
-rw-r--r-- | core/config/project_settings.cpp | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/core/config/project_settings.cpp b/core/config/project_settings.cpp index 0bf7430d84..264883ffa8 100644 --- a/core/config/project_settings.cpp +++ b/core/config/project_settings.cpp @@ -220,7 +220,9 @@ String ProjectSettings::localize_path(const String &p_path) const { void ProjectSettings::set_initial_value(const String &p_name, const Variant &p_value) { ERR_FAIL_COND_MSG(!props.has(p_name), "Request for nonexistent project setting: " + p_name + "."); - props[p_name].initial = p_value; + + // Duplicate so that if value is array or dictionary, changing the setting will not change the stored initial value. + props[p_name].initial = p_value.duplicate(); } void ProjectSettings::set_restart_if_changed(const String &p_name, bool p_restart) { @@ -1122,7 +1124,9 @@ bool ProjectSettings::_property_get_revert(const StringName &p_name, Variant &r_ return false; } - r_property = props[p_name].initial; + // Duplicate so that if value is array or dictionary, changing the setting will not change the stored initial value. + r_property = props[p_name].initial.duplicate(); + return true; } |