diff options
| author | Rémi Verschelde <rverschelde@gmail.com> | 2020-02-23 08:43:18 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-02-23 08:43:18 +0100 |
| commit | bd10c7045865bc7788f695b3ecc4fb136a499d87 (patch) | |
| tree | 17b378d5698fe51bcd2e67aa648e704b29427b88 /SConstruct | |
| parent | 63b0d822d109f3612d5c22e4342ebef9cd3b9163 (diff) | |
| parent | 2cf6ac6c507529884d6b8acfdc42f3bc1826b19d (diff) | |
Merge pull request #36461 from akien-mga/c++17-fallthrough-attribute
Replace FALLTHROUGH macro by C++17 [[fallthrough]]
Diffstat (limited to 'SConstruct')
| -rw-r--r-- | SConstruct | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/SConstruct b/SConstruct index 0c0e7ed681..e20499a756 100644 --- a/SConstruct +++ b/SConstruct @@ -360,8 +360,6 @@ if selected_platform in platform_list: shadow_local_warning = ['-Wshadow-local'] if (env["warnings"] == 'extra'): - # Note: enable -Wimplicit-fallthrough for Clang (already part of -Wextra for GCC) - # once we switch to C++11 or later (necessary for our FALLTHROUGH macro). env.Append(CCFLAGS=['-Wall', '-Wextra', '-Wno-unused-parameter'] + all_plus_warnings + shadow_local_warning) env.Append(CXXFLAGS=['-Wctor-dtor-privacy', '-Wnon-virtual-dtor']) @@ -374,6 +372,8 @@ if selected_platform in platform_list: version = methods.get_compiler_version(env) if version != None and version[0] >= '9': env.Append(CCFLAGS=['-Wattribute-alias=2']) + if methods.using_clang(env): + env.Append(CCFLAGS=['-Wimplicit-fallthrough']) elif (env["warnings"] == 'all'): env.Append(CCFLAGS=['-Wall'] + shadow_local_warning) elif (env["warnings"] == 'moderate'): |