diff options
| author | Rémi Verschelde <remi@verschelde.fr> | 2022-08-07 09:26:39 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-07 09:26:39 +0200 |
| commit | f85a81696569108c8b4e5cd2f747f3e9c2699b1f (patch) | |
| tree | e67dcb40c914ebd33ee23afa27926782c39fd84a | |
| parent | 52c311fc3432313ca66f671d5c61b427c27489d4 (diff) | |
| parent | 25ce459fc5e324227b8ef3b776c8c7e95a3c71a9 (diff) | |
Merge pull request #64025 from kleonc/filesystem-dock-rename-crash-fix
`FileSystemDock` Fix crash when renaming a file in split mode
| -rw-r--r-- | editor/filesystem_dock.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/editor/filesystem_dock.cpp b/editor/filesystem_dock.cpp index 6638e2f42f..b823db68f0 100644 --- a/editor/filesystem_dock.cpp +++ b/editor/filesystem_dock.cpp @@ -1531,14 +1531,13 @@ void FileSystemDock::_folder_removed(String p_folder) { void FileSystemDock::_rename_operation_confirm() { String new_name = rename_dialog_text->get_text().strip_edges(); - String old_name = tree->get_selected()->get_text(0); if (new_name.length() == 0) { EditorNode::get_singleton()->show_warning(TTR("No name provided.")); return; } else if (new_name.contains("/") || new_name.contains("\\") || new_name.contains(":")) { EditorNode::get_singleton()->show_warning(TTR("Name contains invalid characters.")); return; - } else if (to_rename.is_file && old_name.get_extension() != new_name.get_extension()) { + } else if (to_rename.is_file && to_rename.path.get_extension() != new_name.get_extension()) { if (!EditorFileSystem::get_singleton()->get_valid_extensions().find(new_name.get_extension())) { EditorNode::get_singleton()->show_warning(TTR("This file extension is not recognized by the editor.\nIf you want to rename it anyway, use your operating system's file manager.\nAfter renaming to an unknown extension, the file won't be shown in the editor anymore.")); return; |