diff options
author | RĂ©mi Verschelde <remi@verschelde.fr> | 2022-03-30 09:00:07 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-03-30 09:00:07 +0200 |
commit | f6ef63635f92c0a8c9c637c488f0ec129217fade (patch) | |
tree | 742460b66a06af55941583b929c749845fa6c00b | |
parent | a06b94a1c19dc4a64a826cd69c66e17134a5f101 (diff) | |
parent | 619d9d143baff60827249a5592b2117675ae88f1 (diff) |
Merge pull request #59659 from fountainment/fix_callable_bind_usage
Fix Callable::bind usage in connections_dialog.h and packed_scene.cpp
-rw-r--r-- | editor/connections_dialog.h | 7 | ||||
-rw-r--r-- | scene/resources/packed_scene.cpp | 7 |
2 files changed, 10 insertions, 4 deletions
diff --git a/editor/connections_dialog.h b/editor/connections_dialog.h index a075ff0c55..58c584b8b2 100644 --- a/editor/connections_dialog.h +++ b/editor/connections_dialog.h @@ -93,8 +93,11 @@ public: if (unbinds > 0) { return Callable(target, method).unbind(unbinds); } else if (!binds.is_empty()) { - const Variant *args = binds.ptr(); - return Callable(target, method).bind(&args, binds.size()); + const Variant **argptrs = (const Variant **)alloca(sizeof(Variant *) * binds.size()); + for (int i = 0; i < binds.size(); i++) { + argptrs[i] = &binds[i]; + } + return Callable(target, method).bind(argptrs, binds.size()); } else { return Callable(target, method); } diff --git a/scene/resources/packed_scene.cpp b/scene/resources/packed_scene.cpp index a3e356feaf..b1c2702a1e 100644 --- a/scene/resources/packed_scene.cpp +++ b/scene/resources/packed_scene.cpp @@ -362,8 +362,11 @@ Node *SceneState::instantiate(GenEditState p_edit_state) const { } } - const Variant *args = binds.ptr(); - callable = callable.bind(&args, binds.size()); + const Variant **argptrs = (const Variant **)alloca(sizeof(Variant *) * binds.size()); + for (int j = 0; j < binds.size(); j++) { + argptrs[j] = &binds[j]; + } + callable = callable.bind(argptrs, binds.size()); } cfrom->connect(snames[c.signal], callable, varray(), CONNECT_PERSIST | c.flags); |