diff options
author | Rémi Verschelde <remi@verschelde.fr> | 2021-10-24 23:34:08 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-10-24 23:34:08 +0200 |
commit | e71184667ef09e2cd797219ceb598988a9b33801 (patch) | |
tree | 9ddbc7c6b9dfb7f77926429748b2bdcac8f99c96 | |
parent | 69eaa806c8959d5f93a8c863637bcc68931b872c (diff) | |
parent | 2e76d5a3a4ef8929ea6c904d197b3738162c1835 (diff) |
Merge pull request #53707 from Calinou/action-editor-default-enable-physical
-rw-r--r-- | editor/action_map_editor.cpp | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/editor/action_map_editor.cpp b/editor/action_map_editor.cpp index 363d542fd5..fc7e7389d5 100644 --- a/editor/action_map_editor.cpp +++ b/editor/action_map_editor.cpp @@ -571,7 +571,13 @@ void InputEventConfigurationDialog::popup_and_configure(const Ref<InputEvent> &p for (int i = 0; i < MOD_MAX; i++) { mod_checkboxes[i]->set_pressed(false); } - physical_key_checkbox->set_pressed(false); + + // Enable the Physical Key checkbox by default to encourage its use. + // Physical Key should be used for most game inputs as it allows keys to work + // on non-QWERTY layouts out of the box. + // This is especially important for WASD movement layouts. + physical_key_checkbox->set_pressed(true); + store_command_checkbox->set_pressed(true); _set_current_device(0); @@ -702,7 +708,7 @@ InputEventConfigurationDialog::InputEventConfigurationDialog() { physical_key_checkbox = memnew(CheckBox); physical_key_checkbox->set_text(TTR("Use Physical Keycode")); - physical_key_checkbox->set_tooltip(TTR("Stores the physical position of the key on the keyboard rather than the keys value. Used for compatibility with non-latin layouts.")); + physical_key_checkbox->set_tooltip(TTR("Stores the physical position of the key on the keyboard rather than the key's value. Used for compatibility with non-latin layouts.\nThis should generally be enabled for most game shortcuts, but not in non-game applications.")); physical_key_checkbox->connect("toggled", callable_mp(this, &InputEventConfigurationDialog::_physical_keycode_toggled)); physical_key_checkbox->hide(); additional_options_container->add_child(physical_key_checkbox); |