summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRémi Verschelde <rverschelde@gmail.com>2018-09-20 13:43:34 +0200
committerGitHub <noreply@github.com>2018-09-20 13:43:34 +0200
commite5bdf5e37b7d0d0889dce5d0d279555599679a7b (patch)
treef7abbca3c51f6fb3e38e9b727ff263c4c8aa752c
parentd357b45fda65693167e61b61c5d2951edb919844 (diff)
parentbff864818f5b47caf0f789fc61ca8729fb443c83 (diff)
Merge pull request #22250 from ibrahn/shader_lang_vector_gotcha
Fixed an access after free in ShaderLanguage::_reduce_expression.
-rw-r--r--servers/visual/shader_language.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/servers/visual/shader_language.cpp b/servers/visual/shader_language.cpp
index 35236b23f1..4718eb14a5 100644
--- a/servers/visual/shader_language.cpp
+++ b/servers/visual/shader_language.cpp
@@ -3437,8 +3437,9 @@ ShaderLanguage::Node *ShaderLanguage::_reduce_expression(BlockNode *p_block, Sha
}
}
} else {
+ ConstantNode::Value value = values[0];
for (int i = 1; i < cardinality; i++) {
- values.push_back(values[0]);
+ values.push_back(value);
}
}
} else if (values.size() != cardinality) {