summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRĂ©mi Verschelde <rverschelde@gmail.com>2020-06-27 16:50:19 +0200
committerGitHub <noreply@github.com>2020-06-27 16:50:19 +0200
commitc4707bd71bedb461a99112d01bf80239f5ceac56 (patch)
tree3a8421fffebc1b06e181af57ea2a8aa71826dfee
parent759ed89640d5399d9d876b5cedbb1308a1a9f0ac (diff)
parentb2a204799adb290cd63c9c0346574448336d8f02 (diff)
Merge pull request #39850 from adamreichold/is-position-behind-get-global-transform-once
Call Node3D::get_global_transform and Vector3::dot only once within Camera3D::is_position_behind
-rw-r--r--scene/3d/camera_3d.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/scene/3d/camera_3d.cpp b/scene/3d/camera_3d.cpp
index 7ffca4bd9e..689afa5608 100644
--- a/scene/3d/camera_3d.cpp
+++ b/scene/3d/camera_3d.cpp
@@ -318,8 +318,8 @@ Vector3 Camera3D::project_ray_origin(const Point2 &p_pos) const {
bool Camera3D::is_position_behind(const Vector3 &p_pos) const {
Transform t = get_global_transform();
- Vector3 eyedir = -get_global_transform().basis.get_axis(2).normalized();
- return eyedir.dot(p_pos) < (eyedir.dot(t.origin) + near);
+ Vector3 eyedir = -t.basis.get_axis(2).normalized();
+ return eyedir.dot(p_pos - t.origin) < near;
}
Vector<Vector3> Camera3D::get_near_plane_points() const {