diff options
| author | Rémi Verschelde <rverschelde@gmail.com> | 2020-09-07 13:07:02 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-09-07 13:07:02 +0200 |
| commit | b4a831b42e1c79b0edb729174564289aaa3e4dd5 (patch) | |
| tree | b11963063cee05efefc57c408abaea35a049887b | |
| parent | 365dbde25d00520ff3aeb37a37daba2cc3b161e2 (diff) | |
| parent | f515e7234872aa06e1ffbc50ef111e8e989cf160 (diff) | |
Merge pull request #41844 from madmiraal/fix-bitwise-sign-check
Use != 0 instead of > 0 when checking bit mask.
| -rw-r--r-- | scene/gui/base_button.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scene/gui/base_button.cpp b/scene/gui/base_button.cpp index 6fef44481a..aaae03df68 100644 --- a/scene/gui/base_button.cpp +++ b/scene/gui/base_button.cpp @@ -60,7 +60,7 @@ void BaseButton::_gui_input(Ref<InputEvent> p_event) { Ref<InputEventMouseButton> mouse_button = p_event; bool ui_accept = p_event->is_action("ui_accept") && !p_event->is_echo(); - bool button_masked = mouse_button.is_valid() && ((1 << (mouse_button->get_button_index() - 1)) & button_mask) > 0; + bool button_masked = mouse_button.is_valid() && ((1 << (mouse_button->get_button_index() - 1)) & button_mask) != 0; if (button_masked || ui_accept) { on_action_event(p_event); return; |