diff options
author | Micky <micheledevita2@gmail.com> | 2022-11-12 16:01:17 +0100 |
---|---|---|
committer | Micky <micheledevita2@gmail.com> | 2022-11-13 00:01:18 +0100 |
commit | a1c10dbbd8c390b7d0709c61bc31a2d5636c2941 (patch) | |
tree | 1994c6001ef144e164f6b77a591f8f7425ef59e5 | |
parent | c17f17eb98188a7134c85bdbdf0123127c462046 (diff) |
Strip ERR_FAIL from `Node.remove_from_group()`
Also simplifies group check removing unnecessary `!data.grouped.has`
-rw-r--r-- | doc/classes/Node.xml | 2 | ||||
-rw-r--r-- | scene/main/node.cpp | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/doc/classes/Node.xml b/doc/classes/Node.xml index b83bff5d5e..f910112a76 100644 --- a/doc/classes/Node.xml +++ b/doc/classes/Node.xml @@ -606,7 +606,7 @@ <return type="void" /> <param index="0" name="group" type="StringName" /> <description> - Removes a node from a group. See notes in the description, and the group methods in [SceneTree]. + Removes a node from the [param group]. Does nothing if the node is not in the [param group]. See notes in the description, and the group methods in [SceneTree]. </description> </method> <method name="replace_by"> diff --git a/scene/main/node.cpp b/scene/main/node.cpp index 304504a82e..a16bf543d8 100644 --- a/scene/main/node.cpp +++ b/scene/main/node.cpp @@ -1759,11 +1759,11 @@ void Node::add_to_group(const StringName &p_identifier, bool p_persistent) { } void Node::remove_from_group(const StringName &p_identifier) { - ERR_FAIL_COND(!data.grouped.has(p_identifier)); - HashMap<StringName, GroupData>::Iterator E = data.grouped.find(p_identifier); - ERR_FAIL_COND(!E); + if (!E) { + return; + } if (data.tree) { data.tree->remove_from_group(E->key, this); |