diff options
author | RĂ©mi Verschelde <remi@verschelde.fr> | 2022-07-05 21:04:24 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-07-05 21:04:24 +0200 |
commit | 9de5698ee21c2e834eec9b39c2f9e1492ff018d4 (patch) | |
tree | d5681cef29a04dd0868528a46df01785eead5954 | |
parent | 5f386fecf0769626e19d6bb42e11f7663659d9b6 (diff) | |
parent | aa9403bcdaa459bd490cf854ffdf71963a39d5bb (diff) |
Merge pull request #62742 from Calinou/voxelgi-clamp-extents
-rw-r--r-- | doc/classes/VoxelGI.xml | 1 | ||||
-rw-r--r-- | scene/3d/voxel_gi.cpp | 3 |
2 files changed, 3 insertions, 1 deletions
diff --git a/doc/classes/VoxelGI.xml b/doc/classes/VoxelGI.xml index 55ba1c4934..d941185d33 100644 --- a/doc/classes/VoxelGI.xml +++ b/doc/classes/VoxelGI.xml @@ -37,6 +37,7 @@ </member> <member name="extents" type="Vector3" setter="set_extents" getter="get_extents" default="Vector3(10, 10, 10)"> The size of the area covered by the [VoxelGI]. If you make the extents larger without increasing the subdivisions with [member subdiv], the size of each cell will increase and result in lower detailed lighting. + [b]Note:[/b] Extents are clamped to 1.0 unit or more on each axis. </member> <member name="subdiv" type="int" setter="set_subdiv" getter="get_subdiv" enum="VoxelGI.Subdiv" default="1"> Number of times to subdivide the grid that the [VoxelGI] operates on. A higher number results in finer detail and thus higher visual quality, while lower numbers result in better performance. diff --git a/scene/3d/voxel_gi.cpp b/scene/3d/voxel_gi.cpp index d81b59b3fc..ae231026a7 100644 --- a/scene/3d/voxel_gi.cpp +++ b/scene/3d/voxel_gi.cpp @@ -272,7 +272,8 @@ VoxelGI::Subdiv VoxelGI::get_subdiv() const { } void VoxelGI::set_extents(const Vector3 &p_extents) { - extents = p_extents; + // Prevent very small extents as these break baking if other extents are set very high. + extents = Vector3(MAX(1.0, p_extents.x), MAX(1.0, p_extents.y), MAX(1.0, p_extents.z)); update_gizmos(); } |