diff options
author | Rémi Verschelde <rverschelde@gmail.com> | 2018-11-10 21:33:19 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-11-10 21:33:19 +0100 |
commit | 87d27e1250c4be1406b15244901cefb6738a6709 (patch) | |
tree | b13a04e9969a885492e6f61f7fb3aa26c0677290 | |
parent | 3e128a6d8aa2982ec4da20c1dd73faa968b9207a (diff) | |
parent | 7c4c646749772aee235ea5b42b6f1a1f2bfe2b51 (diff) |
Merge pull request #23639 from neikeq/gg
Fix GDScript placeholder fallback
-rw-r--r-- | core/script_language.cpp | 3 | ||||
-rw-r--r-- | modules/gdscript/gdscript.cpp | 7 |
2 files changed, 9 insertions, 1 deletions
diff --git a/core/script_language.cpp b/core/script_language.cpp index 5b65da9ef1..496521486e 100644 --- a/core/script_language.cpp +++ b/core/script_language.cpp @@ -563,7 +563,8 @@ Variant PlaceHolderScriptInstance::property_get_fallback(const StringName &p_nam PlaceHolderScriptInstance::PlaceHolderScriptInstance(ScriptLanguage *p_language, Ref<Script> p_script, Object *p_owner) : owner(p_owner), language(p_language), - script(p_script) { + script(p_script), + build_failed(false) { } PlaceHolderScriptInstance::~PlaceHolderScriptInstance() { diff --git a/modules/gdscript/gdscript.cpp b/modules/gdscript/gdscript.cpp index ef86ccae14..159085df34 100644 --- a/modules/gdscript/gdscript.cpp +++ b/modules/gdscript/gdscript.cpp @@ -469,8 +469,15 @@ bool GDScript::_update_exports() { for (Set<PlaceHolderScriptInstance *>::Element *E = placeholders.front(); E; E = E->next()) { E->get()->set_build_failed(true); } + return false; } } else { + if (!valid) { + for (Set<PlaceHolderScriptInstance *>::Element *E = placeholders.front(); E; E = E->next()) { + E->get()->set_build_failed(true); + } + return false; + } } if (base_cache.is_valid()) { |