summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRémi Verschelde <rverschelde@gmail.com>2020-06-24 16:57:37 +0200
committerRémi Verschelde <rverschelde@gmail.com>2020-06-24 16:58:18 +0200
commit6480efba45ae467e38955012d67857a4a81b752b (patch)
treed7b78452fa416bce405abf90636a47c65baa90bf
parent4c0b077faaff3f0a492bb9f48984da0b13cedc7e (diff)
Main::cleanup: Move MessageQueue deletion further down where it's safer
Partial revert of #15702 which triggered the issue. Fixes #39786.
-rw-r--r--main/main.cpp6
1 files changed, 5 insertions, 1 deletions
diff --git a/main/main.cpp b/main/main.cpp
index 747b12677d..91ff222f57 100644
--- a/main/main.cpp
+++ b/main/main.cpp
@@ -2321,8 +2321,8 @@ void Main::cleanup() {
ResourceLoader::remove_custom_loaders();
ResourceSaver::remove_custom_savers();
+ // Flush before uninitializing the scene, but delete the MessageQueue as late as possible.
message_queue->flush();
- memdelete(message_queue);
OS::get_singleton()->delete_main_loop();
@@ -2408,6 +2408,10 @@ void Main::cleanup() {
OS::get_singleton()->set_restart_on_exit(false, List<String>()); //clear list (uses memory)
}
+ // Now should be safe to delete MessageQueue (famous last words).
+ message_queue->flush();
+ memdelete(message_queue);
+
unregister_core_driver_types();
unregister_core_types();