Merge pull request #42215 from Chaosus/forbid_invalid_varyings

Forbids varying declaration in particles and sky shaders

1 files changed, 8 insertions, 0 deletions

diff --git a/servers/rendering/shader_language.cpp b/servers/rendering/shader_language.cpp
index 28c41fb2dc..6c835fcadf 100644
--- a/servers/rendering/shader_language.cpp
+++ b/servers/rendering/shader_language.cpp
@@ -6099,6 +6099,14 @@ Error ShaderLanguage::_parse_shader(const Map<StringName, FunctionInfo> &p_funct
 			case TK_UNIFORM:
 			case TK_VARYING: {
 				bool uniform = tk.type == TK_UNIFORM;
+
+				if (!uniform) {
+					if (shader_type_identifier == "particles" || shader_type_identifier == "sky") {
+						_set_error(vformat("Varyings cannot be used in '%s' shaders!", shader_type_identifier));
+						return ERR_PARSE_ERROR;
+					}
+				}
+
 				DataPrecision precision = PRECISION_DEFAULT;
 				DataInterpolation interpolation = INTERPOLATION_SMOOTH;
 				DataType type;