summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRémi Verschelde <rverschelde@gmail.com>2023-01-26 01:11:25 +0100
committerRémi Verschelde <rverschelde@gmail.com>2023-01-26 01:11:25 +0100
commit31496c296ad8e18b767fabce996bbce46b10cdf4 (patch)
tree3770d3e55362b4832b290623bf48f07fdaeaeb08
parent4b0363312e9d13349cc7e1cfeff03168206a4da5 (diff)
parent8c25bcdb8484e1cfd0a2d14398a3423d2df9b4c5 (diff)
Merge pull request #72078 from bitsawer/fix_optimize_vertices
Fix range loop iteration regressions
-rw-r--r--core/math/geometry_3d.cpp2
-rw-r--r--servers/rendering/renderer_rd/storage_rd/mesh_storage.cpp2
2 files changed, 2 insertions, 2 deletions
diff --git a/core/math/geometry_3d.cpp b/core/math/geometry_3d.cpp
index 4786110054..590483bf20 100644
--- a/core/math/geometry_3d.cpp
+++ b/core/math/geometry_3d.cpp
@@ -151,7 +151,7 @@ void Geometry3D::MeshData::optimize_vertices() {
}
}
- for (MeshData::Edge edge : edges) {
+ for (MeshData::Edge &edge : edges) {
int a = edge.vertex_a;
int b = edge.vertex_b;
diff --git a/servers/rendering/renderer_rd/storage_rd/mesh_storage.cpp b/servers/rendering/renderer_rd/storage_rd/mesh_storage.cpp
index 46a0d85ba8..2015a2fca0 100644
--- a/servers/rendering/renderer_rd/storage_rd/mesh_storage.cpp
+++ b/servers/rendering/renderer_rd/storage_rd/mesh_storage.cpp
@@ -842,7 +842,7 @@ void MeshStorage::mesh_instance_set_blend_shape_weight(RID p_mesh_instance, int
}
void MeshStorage::_mesh_instance_clear(MeshInstance *mi) {
- for (const RendererRD::MeshStorage::MeshInstance::Surface surface : mi->surfaces) {
+ for (const RendererRD::MeshStorage::MeshInstance::Surface &surface : mi->surfaces) {
if (surface.versions) {
for (uint32_t j = 0; j < surface.version_count; j++) {
RD::get_singleton()->free(surface.versions[j].vertex_array);