diff options
author | Rafał Mikrut <mikrutrafal54@gmail.com> | 2019-12-26 17:38:08 +0100 |
---|---|---|
committer | Rafał Mikrut <mikrutrafal54@gmail.com> | 2019-12-26 17:38:08 +0100 |
commit | 1ac701cc378d002817463d9e4101f8866254fe42 (patch) | |
tree | b69e2fef1a342f9192b4290164e15d71af65ee6a | |
parent | e21872f4b9798c14b2840f205eff7aa931f02c0d (diff) |
Don't use constant reference in Vector push_back, insert and append_array
-rw-r--r-- | core/vector.h | 10 | ||||
-rw-r--r-- | editor/import/editor_scene_importer_gltf.h | 3 |
2 files changed, 8 insertions, 5 deletions
diff --git a/core/vector.h b/core/vector.h index e6bb4a96fc..d78354058f 100644 --- a/core/vector.h +++ b/core/vector.h @@ -63,7 +63,7 @@ private: CowData<T> _cowdata; public: - bool push_back(const T &p_elem); + bool push_back(T p_elem); void remove(int p_index) { _cowdata.remove(p_index); } void erase(const T &p_val) { @@ -83,10 +83,10 @@ public: _FORCE_INLINE_ int size() const { return _cowdata.size(); } Error resize(int p_size) { return _cowdata.resize(p_size); } _FORCE_INLINE_ const T &operator[](int p_index) const { return _cowdata.get(p_index); } - Error insert(int p_pos, const T &p_val) { return _cowdata.insert(p_pos, p_val); } + Error insert(int p_pos, T p_val) { return _cowdata.insert(p_pos, p_val); } int find(const T &p_val, int p_from = 0) const { return _cowdata.find(p_val, p_from); } - void append_array(const Vector<T> &p_other); + void append_array(Vector<T> p_other); template <class C> void sort_custom() { @@ -136,7 +136,7 @@ void Vector<T>::invert() { } template <class T> -void Vector<T>::append_array(const Vector<T> &p_other) { +void Vector<T>::append_array(Vector<T> p_other) { const int ds = p_other.size(); if (ds == 0) return; @@ -147,7 +147,7 @@ void Vector<T>::append_array(const Vector<T> &p_other) { } template <class T> -bool Vector<T>::push_back(const T &p_elem) { +bool Vector<T>::push_back(T p_elem) { Error err = resize(size() + 1); ERR_FAIL_COND_V(err, true); diff --git a/editor/import/editor_scene_importer_gltf.h b/editor/import/editor_scene_importer_gltf.h index 6021bf10c8..173d3ec00e 100644 --- a/editor/import/editor_scene_importer_gltf.h +++ b/editor/import/editor_scene_importer_gltf.h @@ -172,7 +172,10 @@ class EditorSceneImporterGLTF : public EditorSceneImporter { min = 0; max = 0; sparse_count = 0; + sparse_indices_buffer_view = 0; sparse_indices_byte_offset = 0; + sparse_indices_component_type = 0; + sparse_values_buffer_view = 0; sparse_values_byte_offset = 0; } }; |